Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addresses changes asked in comments in patch set 5 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html ('k') | LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item-expected.txt » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html
diff --git a/LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html b/LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html
new file mode 100644
index 0000000000000000000000000000000000000000..b03c084e47abb12b80f3f6e131933f9573c676fe
--- /dev/null
+++ b/LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html
@@ -0,0 +1,87 @@
+<!DOCTYPE html>
+<link href="resources/flexbox.css" rel="stylesheet">
+<style>
+.horizontal {
+ height: 100px;
+ background-color: purple;
+ position: relative;
+}
+
+.vertical {
+ width: 100px;
+ background-color: purple;
+ position: relative;
+ -webkit-writing-mode: vertical-rl;
+}
+
+.flex-one {
+ background-color: red;
+}
+</style>
+<script src="../../resources/check-layout.js"></script>
+<script>
+function changeHeight()
+{
+ document.getElementById('dynamicHorizontalChild').style.height = "90%";
+ document.getElementById('dynamicVerticalChild').style.width = "30%";
+ checkLayout('.flexbox');
+ checkLayout('.flexbox');
+}
+</script>
+<body onload="changeHeight()">
+<div class="flexbox horizontal">
+ <div data-expected-height="100" class="flex-one">
+ <div data-expected-height="70" style="height:70%; background-color:lime">Horizontal Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox vertical">
+ <div data-expected-width="100" class="flex-one">
+ <div data-expected-width="50" style="width: 50%; background-color:lime">Vertical Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox horizontal">
+ <div data-expected-height="100" class="flex-one">
+ <div id="dynamicHorizontalChild" data-expected-height="90" style="height:70%; background-color:lime">Horizontal Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox vertical">
+ <div data-expected-width="100" class="flex-one">
+ <div id="dynamicVerticalChild" data-expected-width="30" style="width: 50%; background-color:lime">Vertical Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox horizontal">
+ <div data-expected-height="100" class="flex-one" style="padding:10px; border:2px solid black">
+ <div data-expected-height="53" style="height:70%; background-color:lime">Horizontal Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox vertical">
+ <div data-expected-width="100" class="flex-one" style="padding:10px; border:2px solid black">
+ <div data-expected-width="38" style="width: 50%; background-color:lime">Vertical Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox horizontal">
+ <img data-expected-height="50" style="max-height:50%" src="../images/resources/green-10.png" />
+</div>
+
+<div class="flexbox vertical">
+ <img data-expected-width="50" style="max-width:50%" src="../images/resources/green-10.png" />
+</div>
+
+<div class="flexbox horizontal">
+ <div data-expected-height="50" class="flex-one" style="max-height:50%">
+ <div data-expected-height="25" style="height:50%; background-color:lime">Horizontal Writing Mode</div>
+ </div>
+</div>
+
+<div class="flexbox vertical">
+ <div data-expected-width="50" class="flex-one" style="max-width:50%">
+ <div data-expected-width="25" style="width: 50%; background-color:lime">Vertical Writing Mode</div>
+ </div>
+</div>
+</body>
« no previous file with comments | « LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html ('k') | LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item-expected.txt » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698