Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Source/core/rendering/RenderFlexibleBox.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1357 matching lines @@
         // FIXME: If the child has orthogonal flow, then it already has an override height set, so use it.
         if (!hasOrthogonalFlow(child)) {
             LayoutUnit heightBeforeStretching = needToStretchChildLogicalHeight(child) ? constrainedChildIntrinsicContentLogicalHeight(child) : child->logicalHeight();
             LayoutUnit stretchedLogicalHeight = heightBeforeStretching + availableAlignmentSpaceForChildBeforeStretching(lineCrossAxisExtent, child);
             ASSERT(!child->needsLayout());
             LayoutUnit desiredLogicalHeight = child->constrainLogicalHeightByMinMax(stretchedLogicalHeight, heightBeforeStretching - child->borderAndPaddingLogicalHeight());
 
             // FIXME: Can avoid laying out here in some cases. See https://webkit.org/b/87905.
             if (desiredLogicalHeight != child->logicalHeight()) {
                 child->setOverrideLogicalContentHeight(desiredLogicalHeight - child->borderAndPaddingLogicalHeight());
+                child->setOverrideContainingBlockContentLogicalHeight(stretchedLogicalHeight - child->borderAndPaddingLogicalHeight());

[cbiesinger, 2014/06/24 03:01:28]

I wrote this comment below before I thought of the suggestion I gave above. I
decided to keep it here in case it is useful for future reference.

---

So, I see in the comments that you changed this from desiredLogicalHeight, but
this new code is wrong. It has to be desiredLogicalHeight, otherwise the
percentage height of the children of the flex item will be incorrect if there's
a max-height on the flex item.

Irrespective of that you do need to clear this width so that the code will work
correctly if the align-self property gets changed from stretch to something
else. Tony's example should be fine because when we mark a node as needing
layout we also mark its ancestors as needing layout, but you should add a test
to make sure.

[harpreet.sk, 2014/06/24 07:57:00]

I had made the changes to add desiredLogicalHeight instead of
stretchedLogicalHeight and clearing the 
overrideContainingBlockContentLogicalHeight afterwards. 
The case tony mention of updating height of grandchild to different percent
value is already there in layouttest.

                 child->setLogicalHeight(0);
                 child->forceChildLayout();
             }
         }
     } else if (isColumnFlow() && child->style()->logicalWidth().isAuto()) {
         // FIXME: If the child doesn't have orthogonal flow, then it already has an override width set, so use it.
         if (hasOrthogonalFlow(child)) {
             LayoutUnit childWidth = std::max<LayoutUnit>(0, lineCrossAxisExtent - crossAxisMarginExtentForChild(child));
             childWidth = child->constrainLogicalWidthByMinMax(childWidth, childWidth, this);
 
@@ skipping 31 matching lines @@
             ASSERT(child);
             LayoutUnit lineCrossAxisExtent = lineContexts[lineNumber].crossAxisExtent;
             LayoutUnit originalOffset = lineContexts[lineNumber].crossAxisOffset - crossAxisStartEdge;
             LayoutUnit newOffset = contentExtent - originalOffset - lineCrossAxisExtent;
             adjustAlignmentForChild(child, newOffset - originalOffset);
         }
     }
 }
 
 }