Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2658 matching lines @@
     // A positioned element that specified both top/bottom or that specifies height should be treated as though it has a height
     // explicitly specified that can be used for any percentage computations.
     bool isOutOfFlowPositionedWithSpecifiedHeight = cb->isOutOfFlowPositioned() && (!cbstyle->logicalHeight().isAuto() || (!cbstyle->logicalTop().isAuto() && !cbstyle->logicalBottom().isAuto()));
 
     bool includeBorderPadding = isTable();
 
     if (isHorizontalWritingMode() != cb->isHorizontalWritingMode())
         availableHeight = containingBlockChild->containingBlockLogicalWidthForContent();
     else if (hasOverrideContainingBlockLogicalHeight())
         availableHeight = overrideContainingBlockContentLogicalHeight();
+    else if (cb->hasOverrideContainingBlockLogicalHeight())

[cbiesinger, 2014/06/24 03:01:28]

So, we're now giving overrideContainingBlockLogicalHeight a new meaning. In
fact, it now has *two* incompatible meanings. That doesn't seem right? At the
very least, it seems confusing.

Cunningly, this will actually not break percentage sizing the flex item  itself
due to the child->style()->logicalHeight().isAuto() check and the ordering of
applying min/max, though perhaps that could cause problems with later relayouts.

But does this work correctly in all cases with grid?

How about making this much simpler: change this code to

  else if (cb->isFlexItemIncludingDeprecated())
      availableHeight = cb->overrideLogicalContentHeight();

(actually, we should probably add an isFlexItem() function that doesn't include
deprecated)

Then, you shouldn't even have to change RenderFlexibleBox.

[harpreet.sk, 2014/06/24 07:56:59]

We simply cannot change the code as 

else if (cb->isFlexItemIncludingDeprecated()) 
    availableHeight = cb->overrideLogicalContentHeight();

It will cause the browser to crash for our test cases. It is because it enters
the given api first without cb->overrideLogicalContentHeight being set. So with
this condtion becoming true will call overrideLogicalContentHeight which does
not exist and hence it will get crash.

 Currently the code

 else if (cb->hasOverrideLogicalContentHeight()) 
    availableHeight = cb->overrideLogicalContentHeight();

 is working fine for all the cases for grid but to avoid problems in future
relayouts we can add an additional check of isFlexItem(). In my new patch i have
added this check in order to avoid porblem.
Added the api isFlexItem() in RenderBox.h

+        availableHeight = cb->overrideContainingBlockContentLogicalHeight();
     else if (cb->isTableCell()) {
         if (!skippedAutoHeightContainingBlock) {
             // Table cells violate what the CSS spec says to do with heights. Basically we
             // don't care if the cell specified a height or not. We just always make ourselves
             // be a percentage of the cell's current content height.
             if (!cb->hasOverrideHeight()) {
                 // Normally we would let the cell size intrinsically, but scrolling overflow has to be
                 // treated differently, since WinIE lets scrolled overflow regions shrink as needed.
                 // While we can't get all cases right, we can at least detect when the cell has a specified
                 // height or when the table has a specified height. In these cases we want to initially have
@@ skipping 1957 matching lines @@
         return 0;
 
     if (!layoutState && !flowThreadContainingBlock())
         return 0;
 
     RenderBlock* containerBlock = containingBlock();
     return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
 }
 
 } // namespace WebCore