LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html - Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item.html

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patch set Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html ('k') | LayoutTests/css3/flexbox/percent-height-children-of-alignSelf-stretch-flex-item-expected.txt » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .flexbox-horizontal {

	4 display: flex;

	5 height: 100px;

	6 background-color: purple;

	7 position: relative;

	8 }

	9

	10 .flexbox-vertical {

	11 display: flex;

	12 width: 100px;

	13 background-color: purple;

	14 position: relative;

	15 -webkit-writing-mode: vertical-rl;

	16 }

	17

	18 .flex-item {

	19 flex: 1;

	20 background-color: red;

	21 }

	22 </style>

	23 <script src="../../resources/check-layout.js"></script>

	24 <body onload="checkLayout('.flexbox-horizontal'); checkLayout('.flexbox-vertical ')">

	25 <div class="flexbox-horizontal">

	26 <div data-expected-height="100" class="flex-item">

	27 <div data-expected-height="70" style="height: 70%; background-color:lime">Ho rizontal Writing Mode</div>
	tony 2014/06/19 16:37:46 Please add tests with padding and borders. Also a Please add tests with padding and borders. Also add a test case that changes the height of the grandchild in JS. harpreet.sk 2014/06/20 14:54:32 Done. Show quoted text On 2014/06/19 16:37:46, tony wrote: > Please add tests with padding and borders. Also add a test case that changes > the height of the grandchild in JS. Done.
	28 </div>

	29 </div>

	30

	31 <div class="flexbox-vertical">

	32 <div data-expected-width="100" class="flex-item">

	33 <div data-expected-width="50" style="width: 50%; background-color:lime">Vert ical Writing Mode</div>

	34 </div>

	35 </div>

	36 </body>

OLD	NEW