Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 331203002: Blink doesn't honor percent heights on children of "align-self:stretch" flex items in a fixed-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock. 535 virtual int inlineBlockBaseline(LineDirectionMode) const { return -1; } // R eturns -1 if we should skip this box when computing the baseline of an inline-bl ock.
536 536
537 bool shrinkToAvoidFloats() const; 537 bool shrinkToAvoidFloats() const;
538 virtual bool avoidsFloats() const; 538 virtual bool avoidsFloats() const;
539 539
540 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&); 540 virtual void markForPaginationRelayoutIfNeeded(SubtreeLayoutScope&);
541 541
542 bool isWritingModeRoot() const { return !parent() || parent()->style()->writ ingMode() != style()->writingMode(); } 542 bool isWritingModeRoot() const { return !parent() || parent()->style()->writ ingMode() != style()->writingMode(); }
543 543
544 bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOf FlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); } 544 bool isDeprecatedFlexItem() const { return !isInline() && !isFloatingOrOutOf FlowPositioned() && parent() && parent()->isDeprecatedFlexibleBox(); }
545 bool isFlexItem() const { return !isInline() && !isFloatingOrOutOfFlowPositi oned() && parent() && parent()->isFlexibleBox(); }
545 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDepreca ted(); } 546 bool isFlexItemIncludingDeprecated() const { return !isInline() && !isFloati ngOrOutOfFlowPositioned() && parent() && parent()->isFlexibleBoxIncludingDepreca ted(); }
546 547
547 virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositio nMode = PositionOnContainingLine) const OVERRIDE; 548 virtual LayoutUnit lineHeight(bool firstLine, LineDirectionMode, LinePositio nMode = PositionOnContainingLine) const OVERRIDE;
548 virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode , LinePositionMode = PositionOnContainingLine) const OVERRIDE; 549 virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode , LinePositionMode = PositionOnContainingLine) const OVERRIDE;
549 550
550 virtual LayoutUnit offsetLeft() const OVERRIDE; 551 virtual LayoutUnit offsetLeft() const OVERRIDE;
551 virtual LayoutUnit offsetTop() const OVERRIDE; 552 virtual LayoutUnit offsetTop() const OVERRIDE;
552 553
553 LayoutPoint flipForWritingModeForChild(const RenderBox* child, const LayoutP oint&) const; 554 LayoutPoint flipForWritingModeForChild(const RenderBox* child, const LayoutP oint&) const;
554 LayoutUnit flipForWritingMode(LayoutUnit position) const; // The offset is i n the block direction (y for horizontal writing modes, x for vertical writing mo des). 555 LayoutUnit flipForWritingMode(LayoutUnit position) const; // The offset is i n the block direction (y for horizontal writing modes, x for vertical writing mo des).
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 if (UNLIKELY(inlineBoxWrapper() != 0)) 782 if (UNLIKELY(inlineBoxWrapper() != 0))
782 deleteLineBoxWrapper(); 783 deleteLineBoxWrapper();
783 } 784 }
784 785
785 ensureRareData().m_inlineBoxWrapper = boxWrapper; 786 ensureRareData().m_inlineBoxWrapper = boxWrapper;
786 } 787 }
787 788
788 } // namespace blink 789 } // namespace blink
789 790
790 #endif // RenderBox_h 791 #endif // RenderBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698