Plumbs through window.chrome.setSuggestResult.

Plumbs through window.chrome.setSuggestResult. It's currently hidden behind a flag.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59165

[Mike Belshe, 2010-09-10 18:15:06]

LGTM if you are comfortable with the one note I added.

http://codereview.chromium.org/3312017/diff/2001/3014
File chrome/renderer/search_extension.cc (right):

http://codereview.chromium.org/3312017/diff/2001/3014#newcode45
chrome/renderer/search_extension.cc:45: "chrome.setSuggestResult =
function(text) {"
note: This function will be available to anyone that wants to call it.  For
instance, someone could write an extension which calls this function with a
bunch of spam.  Do we want to allow that?

http://codereview.chromium.org/3312017/diff/2001/3014#newcode65
chrome/renderer/search_extension.cc:65: if (!webframe) return NULL;
nit:  are we supposed to break this to two lines?

[sky, 2010-09-10 18:36:09]

On Fri, Sep 10, 2010 at 11:15 AM,  <mbelshe@chromium.org> wrote:
> LGTM if you are comfortable with the one note I added.
>
>
> http://codereview.chromium.org/3312017/diff/2001/3014
> File chrome/renderer/search_extension.cc (right):
>
> http://codereview.chromium.org/3312017/diff/2001/3014#newcode45
> chrome/renderer/search_extension.cc:45: "chrome.setSuggestResult =
> function(text) {"
> note: This function will be available to anyone that wants to call it.
> For instance, someone could write an extension which calls this function
> with a bunch of spam.  Do we want to allow that?

I'm ok with that for now as I'm going to verify the message in the
browser. Is there a better way where I can tell the renderer to only
enable for a specific page?

  -Scott

> http://codereview.chromium.org/3312017/diff/2001/3014#newcode65
> chrome/renderer/search_extension.cc:65: if (!webframe) return NULL;
> nit:  are we supposed to break this to two lines?
>
> http://codereview.chromium.org/3312017/show
>