Issue 331193004: Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 331193004: Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org, jcgregorio

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Temporarily limit x86 SIMD to SSE2 only, to see effect on all benches and bots. BUG=372232 Committed: https://skia.googlesource.com/skia/+/f1e5a04832e4d350f9ebf5d556c6d3897345f883

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/opts/opts_check_x86.cpp	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm good candidate for adding the ability to get bench results from a try-run

6 years, 6 months ago (2014-06-16 17:08:13 UTC) #2

borenet

On 2014/06/16 17:08:13, reed1 wrote: > lgtm > > good candidate for adding the ability ...

6 years, 6 months ago (2014-06-16 17:09:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/331193004/1

6 years, 6 months ago (2014-06-16 17:10:08 UTC) #5

commit-bot: I haz the power

Change committed as f1e5a04832e4d350f9ebf5d556c6d3897345f883

6 years, 6 months ago (2014-06-16 17:22:17 UTC) #6

mtklein

6 years, 6 months ago (2014-06-16 20:10:28 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/332213005/ by mtklein@google.com.

The reason for reverting is: Experiment is over: disabling SSSE3 is a 25-50%
perf regression for bitmap scaling on every machine we've got..

Expand Messages | Collapse Messages