enterprise.platformKeys: Respect the 'hash' argument of generateKey.

chrome/common/extensions/api/enterprise_platform_keys_internal.idl

Index: chrome/common/extensions/api/enterprise_platform_keys_internal.idl
diff --git a/chrome/common/extensions/api/enterprise_platform_keys_internal.idl b/chrome/common/extensions/api/enterprise_platform_keys_internal.idl
index b6d8f06faaeb2bd88720caf337311290988bc35e..81a0e5bd304d5d90d88c5c712bcd94a20720c192 100644
--- a/chrome/common/extensions/api/enterprise_platform_keys_internal.idl
+++ b/chrome/common/extensions/api/enterprise_platform_keys_internal.idl
@@ -38,12 +38,15 @@ namespace enterprise.platformKeysInternal {
     // |tokenId| The id of a Token returned by |getTokens|.
     // |publicKey| The Subject Public Key Info of a key previously generated by
     //     |generateKey| in DER encoding.
+    // |hashAlgorithmName| The name of the hash algorithm, must be one of
+    //     SHA-{1,256,384,512}.

[not at google - send to devlin, 2014/06/16 17:05:32]

make it an enum?

[pneubeck (no reviews), 2014/06/17 09:12:17]

This is a property forwarded from the Key.algorithm dictionary. I don't want to
translate these values and instead forward them without modification. (added a
comment for that)

I could still add an enum, _if_ the current idl_parser would correctly support
arbitrary strings for enum values. But it parses them as values and thus
interprets the '-'.

I'll post a bug for that, and if fixed I can add an enum here.

[not at google - send to devlin, 2014/06/17 18:18:48]

Ah, right. That seems like a schema compiler problem and should be pretty easy
to fix actually, like, convert - to _ in the enum names. The string value
conversions should stay the same.

     // |data| The data to sign.
     // |callback| Called back with the signature of |data|.
     // TODO: Instead of ArrayBuffer should be (ArrayBuffer or ArrayBufferView),
     // or at least (ArrayBuffer or Uint8Array).
     static void sign(DOMString tokenId,
                      ArrayBuffer publicKey,
+                     DOMString hashAlgorithmName,
                      ArrayBuffer data,
                      SignCallback callback);
   };