Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/browser/android/provider/chrome_browser_provider.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/provider/chrome_browser_provider.cc
diff --git a/chrome/browser/android/provider/chrome_browser_provider.cc b/chrome/browser/android/provider/chrome_browser_provider.cc
index 2e77c8e9b85bdcd76c8c069362a56f315bacd79f..188c286707137912ffdb89110cfe61e0e8fd3fd2 100644
--- a/chrome/browser/android/provider/chrome_browser_provider.cc
+++ b/chrome/browser/android/provider/chrome_browser_provider.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/android/provider/chrome_browser_provider.h"
+#include <cmath>
#include <list>
#include <utility>
@@ -683,14 +684,13 @@ class BookmarkIconFetchTask : public FaviconServiceTask {
favicon_base::FaviconRawBitmapResult Run(const GURL& url) {
float max_scale = ui::GetScaleForScaleFactor(
ResourceBundle::GetSharedInstance().GetMaxScaleFactor());
+ int desired_size_in_pixel = std::ceil(gfx::kFaviconSize * max_scale);
RunAsyncRequestOnUIThreadBlocking(
base::Bind(&FaviconService::GetRawFaviconForPageURL,
base::Unretained(service()),
- FaviconService::FaviconForPageURLParams(
- url,
- favicon_base::FAVICON | favicon_base::TOUCH_ICON,
- gfx::kFaviconSize),
- max_scale,
+ url,
+ favicon_base::FAVICON | favicon_base::TOUCH_ICON,
+ desired_size_in_pixel,
base::Bind(&BookmarkIconFetchTask::OnFaviconRetrieved,
base::Unretained(this)),
cancelable_tracker()));

Powered by Google App Engine
This is Rietveld 408576698