components/bookmarks/browser/bookmark_client.cc - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_client.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_client.cc

diff --git a/components/bookmarks/browser/bookmark_client.cc b/components/bookmarks/browser/bookmark_client.cc

index a7bb764c2ec55c37ebcaa9d8ae22773b7e5b8fd2..fc22f3ac51a536942c3bc39bceda885d77683e74 100644

--- a/components/bookmarks/browser/bookmark_client.cc

+++ b/components/bookmarks/browser/bookmark_client.cc

@@ -12,10 +12,9 @@ bool BookmarkClient::PreferTouchIcon() {

return false;

}

-base::CancelableTaskTracker::TaskId BookmarkClient::GetFaviconImageForURL(

+base::CancelableTaskTracker::TaskId BookmarkClient::GetFaviconImageForPageURL(

const GURL& page_url,

- int icon_types,

- int desired_size_in_dip,

+ favicon_base::IconType type,

const favicon_base::FaviconImageCallback& callback,

base::CancelableTaskTracker* tracker) {

return base::CancelableTaskTracker::kBadTaskId;