chrome/browser/ui/webui/extensions/extension_icon_source.cc - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_icon_source.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_icon_source.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_icon_source.cc b/chrome/browser/ui/webui/extensions/extension_icon_source.cc

index ac106e1c2ca7c4ddec93fb2b732fd50bfd9f87b6..b4f9f336e552dbc059715110bdc0af88fe5ee157 100644

--- a/chrome/browser/ui/webui/extensions/extension_icon_source.cc

+++ b/chrome/browser/ui/webui/extensions/extension_icon_source.cc

@@ -220,9 +220,9 @@ void ExtensionIconSource::LoadFaviconImage(int request_id) {

GURL favicon_url =

AppLaunchInfo::GetFullLaunchURL(GetData(request_id)->extension);

favicon_service->GetRawFaviconForPageURL(

- FaviconService::FaviconForPageURLParams(

- favicon_url, favicon_base::FAVICON, gfx::kFaviconSize),

- 1.0f,

+ favicon_url,

+ favicon_base::FAVICON,

+ gfx::kFaviconSize,

base::Bind(&ExtensionIconSource::OnFaviconDataAvailable,

base::Unretained(this),

request_id),