Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/favicon_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
index d04a290a1597b429d75d97be03f981a64fb09f38..f347ea23f6f86e938d15f963520d5caeebae1808 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
@@ -69,7 +69,7 @@ public class FaviconHelper {
* @param profile Profile used for the FaviconService construction.
* @param pageUrl The target Page URL to get the favicon.
* @param iconTypes One of the IconType class values.
- * @param desiredSizeInDip The size of the favicon in dip we want to get.
+ * @param desiredSizeInPixel The size of the favicon in pixel we want to get.
* @param faviconImageCallback A method to be called back when the result is available.
* Note that this callback is not called if this method returns
* false.
@@ -77,10 +77,10 @@ public class FaviconHelper {
*/
public boolean getLocalFaviconImageForURL(
Profile profile, String pageUrl, int iconTypes,
- int desiredSizeInDip, FaviconImageCallback faviconImageCallback) {
+ int desiredSizeInPixel, FaviconImageCallback faviconImageCallback) {
assert mNativeFaviconHelper != 0;
return nativeGetLocalFaviconImageForURL(mNativeFaviconHelper, profile, pageUrl, iconTypes,
- desiredSizeInDip, faviconImageCallback);
+ desiredSizeInPixel, faviconImageCallback);
}
/**
« no previous file with comments | « no previous file | chrome/browser/android/favicon_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698