Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/history_menu_bridge.h" 5 #include "chrome/browser/ui/cocoa/history_menu_bridge.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 14 matching lines...) Expand all
25 #include "content/public/browser/notification_registrar.h" 25 #include "content/public/browser/notification_registrar.h"
26 #include "content/public/browser/notification_source.h" 26 #include "content/public/browser/notification_source.h"
27 #include "grit/generated_resources.h" 27 #include "grit/generated_resources.h"
28 #include "grit/theme_resources.h" 28 #include "grit/theme_resources.h"
29 #include "grit/ui_resources.h" 29 #include "grit/ui_resources.h"
30 #include "skia/ext/skia_utils_mac.h" 30 #include "skia/ext/skia_utils_mac.h"
31 #include "third_party/skia/include/core/SkBitmap.h" 31 #include "third_party/skia/include/core/SkBitmap.h"
32 #include "ui/base/l10n/l10n_util.h" 32 #include "ui/base/l10n/l10n_util.h"
33 #include "ui/base/resource/resource_bundle.h" 33 #include "ui/base/resource/resource_bundle.h"
34 #include "ui/gfx/codec/png_codec.h" 34 #include "ui/gfx/codec/png_codec.h"
35 #include "ui/gfx/favicon_size.h"
36 #include "ui/gfx/image/image.h" 35 #include "ui/gfx/image/image.h"
37 36
38 namespace { 37 namespace {
39 38
40 // Menus more than this many chars long will get trimmed. 39 // Menus more than this many chars long will get trimmed.
41 const NSUInteger kMaximumMenuWidthInChars = 50; 40 const NSUInteger kMaximumMenuWidthInChars = 50;
42 41
43 // When trimming, use this many chars from each side. 42 // When trimming, use this many chars from each side.
44 const NSUInteger kMenuTrimSizeInChars = 25; 43 const NSUInteger kMenuTrimSizeInChars = 25;
45 44
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 GetFaviconForHistoryItem(item); 449 GetFaviconForHistoryItem(item);
451 450
452 return item; 451 return item;
453 } 452 }
454 453
455 void HistoryMenuBridge::GetFaviconForHistoryItem(HistoryItem* item) { 454 void HistoryMenuBridge::GetFaviconForHistoryItem(HistoryItem* item) {
456 FaviconService* service = 455 FaviconService* service =
457 FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS); 456 FaviconServiceFactory::GetForProfile(profile_, Profile::EXPLICIT_ACCESS);
458 base::CancelableTaskTracker::TaskId task_id = 457 base::CancelableTaskTracker::TaskId task_id =
459 service->GetFaviconImageForPageURL( 458 service->GetFaviconImageForPageURL(
460 FaviconService::FaviconForPageURLParams( 459 item->url,
461 item->url, favicon_base::FAVICON, gfx::kFaviconSize),
462 base::Bind( 460 base::Bind(
463 &HistoryMenuBridge::GotFaviconData, base::Unretained(this), item), 461 &HistoryMenuBridge::GotFaviconData, base::Unretained(this), item),
464 &cancelable_task_tracker_); 462 &cancelable_task_tracker_);
465 item->icon_task_id = task_id; 463 item->icon_task_id = task_id;
466 item->icon_requested = true; 464 item->icon_requested = true;
467 } 465 }
468 466
469 void HistoryMenuBridge::GotFaviconData( 467 void HistoryMenuBridge::GotFaviconData(
470 HistoryItem* item, 468 HistoryItem* item,
471 const favicon_base::FaviconImageResult& image_result) { 469 const favicon_base::FaviconImageResult& image_result) {
(...skipping 12 matching lines...) Expand all
484 } 482 }
485 483
486 void HistoryMenuBridge::CancelFaviconRequest(HistoryItem* item) { 484 void HistoryMenuBridge::CancelFaviconRequest(HistoryItem* item) {
487 DCHECK(item); 485 DCHECK(item);
488 if (item->icon_requested) { 486 if (item->icon_requested) {
489 cancelable_task_tracker_.TryCancel(item->icon_task_id); 487 cancelable_task_tracker_.TryCancel(item->icon_task_id);
490 item->icon_requested = false; 488 item->icon_requested = false;
491 item->icon_task_id = base::CancelableTaskTracker::kBadTaskId; 489 item->icon_task_id = base::CancelableTaskTracker::kBadTaskId;
492 } 490 }
493 } 491 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/navigation_popup.cc ('k') | chrome/browser/ui/search_engines/template_url_table_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698