Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 331143003: Cancel tasks in PeerConnectionHandler mock at stop. (Closed)

Created:
6 years, 6 months ago by Henrik Grunell
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cancel tasks in PeerConnectionHandler mock at stop. This makes sure no callbacks come after stop, which is the expected behavior. BUG=373690 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Henrik Grunell
6 years, 6 months ago (2014-06-16 08:57:15 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-16 12:52:01 UTC) #2
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 6 months ago (2014-06-16 13:56:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/331143003/1
6 years, 6 months ago (2014-06-16 13:57:49 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 16:12:46 UTC) #5
Message was sent while issue was closed.
Change committed as 277458

Powered by Google App Engine
This is Rietveld 408576698