aw: Remove legacy rendering path

android_webview/browser/hardware_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/hardware_renderer.h"
 
 #include "android_webview/browser/aw_gl_surface.h"
 #include "android_webview/browser/deferred_gpu_command_service.h"
 #include "android_webview/browser/parent_output_surface.h"
 #include "android_webview/browser/shared_renderer_state.h"
@@ skipping 106 matching lines @@
 }
 
 void HardwareRenderer::DidBeginMainFrame() {
   // This is called after OutputSurface is created, but before the impl frame
   // starts. We set the draw constraints here.
   DCHECK(output_surface_);
   DCHECK(viewport_clip_valid_for_dcheck_);
   output_surface_->SetDrawConstraints(viewport_, clip_);
 }
 
 bool HardwareRenderer::DrawGL(bool stencil_enabled,

[hush (inactive), 2014/06/16 21:41:50]

what is this? why is it not used?

[boliu, 2014/06/16 22:43:27]

Ehh...I think I dropped this accidentally.

So when functor is called, frameworks gives us a clip, which is a rectangle. But
if the view is rotated in 3d, the "clip" isn't a rectangle, in which case
framework should set the stencil properly before calling us, and we tell the
compositor to use the existing stencil. It's an edge case that's clearly been
broken accidentally for a few months and no one noticed...

Right now, we should do it in the parent compositor now, which is here. This
means plumbing in SyncCompositor can be removed again :)

Going to fix this first separately before landing this.

                               int framebuffer_binding_ext,
-                              AwDrawGLInfo* draw_info,
-                              DrawGLResult* result) {
+                              AwDrawGLInfo* draw_info) {
   TRACE_EVENT0("android_webview", "HardwareRenderer::DrawGL");
 
   // We need to watch if the current Android context has changed and enforce
   // a clean-up in the compositor.
   EGLContext current_context = eglGetCurrentContext();
   if (!current_context) {
     DLOG(ERROR) << "DrawGL called without EGLContext";
     return false;
   }
 
@@ skipping 82 matching lines @@
 }
 
 void HardwareRenderer::UnusedResourcesAreAvailable() {
   cc::ReturnedResourceArray returned_resources;
   resource_collection_->TakeUnusedResourcesForChildCompositor(
       &returned_resources);
   shared_renderer_state_->InsertReturnedResources(returned_resources);
 }
 
 }  // namespace android_webview