Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 331063006: Fix HTMLMediaElement "direction of playback" behavior. (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 6 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix HTMLMediaElement "direction of playback" behavior. This change cleans up the code a little to make it easier to see that the "direction of playback" is being used and corrects the definition of "forward" to include playbackRate == 0. New test cases were added to expose the change in behavior. BUG=385343 TESTS=LayoutTests/media/media-ended.html LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -8 lines) Patch
M LayoutTests/media/media-ended.html View 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/media/media-ended-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/media/video-seek-to-duration-with-playbackrate-zero-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 6 months ago (2014-06-16 23:07:50 UTC) #1
adamk
lgtm
6 years, 6 months ago (2014-06-16 23:15:50 UTC) #2
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 6 months ago (2014-06-16 23:17:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/331063006/1
6 years, 6 months ago (2014-06-16 23:17:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 01:08:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12192)
6 years, 6 months ago (2014-06-17 01:08:57 UTC) #6
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 6 months ago (2014-06-17 01:21:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/331063006/1
6 years, 6 months ago (2014-06-17 01:22:01 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 02:00:18 UTC) #9
Message was sent while issue was closed.
Change committed as 176264

Powered by Google App Engine
This is Rietveld 408576698