Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one f…

chrome/common/extensions/api/bookmark_manager_private.json

Index: chrome/common/extensions/api/bookmark_manager_private.json
diff --git a/chrome/common/extensions/api/bookmark_manager_private.json b/chrome/common/extensions/api/bookmark_manager_private.json
index a965d17f9e17e37d082ffcb58f15165053a99c98..d82c092b70746ba21663dc5dbf98250d9e99f402 100644
--- a/chrome/common/extensions/api/bookmark_manager_private.json
+++ b/chrome/common/extensions/api/bookmark_manager_private.json
@@ -49,6 +49,12 @@
         "type": "object",
         "description": "Collection of meta info fields.",
         "additionalProperties": {"type": "string"}
+      },
+      {
+        "id": "MapMetaInfoFields",
+        "type": "object",
+        "description": "Map Id to MetaInfoFields.",
+        "additionalProperties": {"type": "any"}
       }
     ],
     "functions": [
@@ -269,10 +275,12 @@
         "name": "getMetaInfo",
         "type": "function",
         "description": "Gets meta info from a bookmark node",
+        "allowAmbiguousOptionalArguments": true,
         "parameters": [
           {
             "name": "id",
-            "description": "The id of the bookmark to retrieve meta info from",
+            "description": "The id of the bookmark to retrieve meta info from. If omitted meta info for all nodes is returned.",
+            "optional": true,
             "type": "string"
           },
           {
@@ -287,13 +295,14 @@
             "parameters": [
               {
                 "name": "value",
-                "description": "If a key was given, the value of the specified field, if present. Otherwise an object containing all meta info fields for the node.",
+                "description": "If a key was given, the value of the specified field, if present. Otherwise an object containing all meta info fields for the node. If id is not given then meta info for all nodes as an object with node id to meta info.",
                 "optional": true,
                 // TODO(rfevang): Convert this to always return MetaInfoFields
                 // if the API is made public.
                 "choices": [
                   {"type": "string"},
-                  {"$ref": "MetaInfoFields"}
+                  {"$ref": "MetaInfoFields"},
+                  {"$ref": "MapMetaInfoFields"}

[not at google - send to devlin, 2014/06/16 19:09:13]

I'm puzzled how this works. There is no way for the schema compiler to tell
between two choices of objects.

[yefimt, 2014/06/16 21:47:29]

Removed  {"$ref": "MetaInfoFields"} to resolve ambiguity

On 2014/06/16 19:09:13, kalman wrote:

                 ]
               }
             ]