Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4884)

Unified Diff: chrome/common/extensions/api/bookmark_manager_private.json

Issue 330983002: Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one f… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/bookmark_manager_private.json
diff --git a/chrome/common/extensions/api/bookmark_manager_private.json b/chrome/common/extensions/api/bookmark_manager_private.json
index a965d17f9e17e37d082ffcb58f15165053a99c98..c536041065b62a48511760e07e16290ed4cf185a 100644
--- a/chrome/common/extensions/api/bookmark_manager_private.json
+++ b/chrome/common/extensions/api/bookmark_manager_private.json
@@ -269,10 +269,12 @@
"name": "getMetaInfo",
"type": "function",
"description": "Gets meta info from a bookmark node",
+ "allowAmbiguousOptionalArguments": true,
"parameters": [
{
"name": "id",
- "description": "The id of the bookmark to retrieve meta info from",
+ "description": "The id of the bookmark to retrieve meta info from. If omitted meta info for all nodes is returned.",
+ "optional": true,
"type": "string"
},
{
@@ -287,13 +289,11 @@
"parameters": [
{
"name": "value",
- "description": "If a key was given, the value of the specified field, if present. Otherwise an object containing all meta info fields for the node.",
+ "description": "If a key was given, the value of the specified field, if present. Otherwise an object containing all meta info fields for the node. If id is not given then meta info for all nodes as an object with node id to meta info.",
"optional": true,
- // TODO(rfevang): Convert this to always return MetaInfoFields
- // if the API is made public.
"choices": [
{"type": "string"},
- {"$ref": "MetaInfoFields"}
+ {"type": "object", "additionalProperties": {"type": "any"}}
]
}
]
« no previous file with comments | « chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698