Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 330983002: Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one f… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
index b6e4c02b42c5f53fdff52f0e695797296822630c..dfe9c0cc651358b2146eb8b035e2f620f34fe999 100644
--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
@@ -666,25 +666,47 @@ bool BookmarkManagerPrivateGetMetaInfoFunction::RunOnReady() {
scoped_ptr<GetMetaInfo::Params> params(GetMetaInfo::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
- const BookmarkNode* node = GetBookmarkNodeFromId(params->id);
- if (!node)
- return false;
+ if (params->id) {
+ const BookmarkNode* node = GetBookmarkNodeFromId(*params->id);
+ if (!node)
+ return false;
- if (params->key) {
- std::string value;
- if (node->GetMetaInfo(*params->key, &value)) {
+ if (params->key) {
+ std::string value;
+ if (node->GetMetaInfo(*params->key, &value)) {
+ GetMetaInfo::Results::Value result;
+ result.as_string.reset(new std::string(value));
+ results_ = GetMetaInfo::Results::Create(result);
+ }
+ } else {
GetMetaInfo::Results::Value result;
- result.as_string.reset(new std::string(value));
+ result.as_object.reset(new GetMetaInfo::Results::Value::Object);
+
+ const BookmarkNode::MetaInfoMap* meta_info = node->GetMetaInfoMap();
+ if (meta_info) {
+ BookmarkNode::MetaInfoMap::const_iterator itr;
+ base::DictionaryValue& temp = result.as_object->additional_properties;
+ for (itr = meta_info->begin(); itr != meta_info->end(); itr++) {
+ temp.SetStringWithoutPathExpansion(itr->first, itr->second);
+ }
+ }
results_ = GetMetaInfo::Results::Create(result);
}
} else {
+ if (params->key) {
+ error_ = bookmark_api_constants::kInvalidParamError;
+ return true;
+ }
+
+ BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
+ const BookmarkNode* node = model->root_node();
+
GetMetaInfo::Results::Value result;
- result.as_meta_info_fields.reset(
- new bookmark_manager_private::MetaInfoFields);
+ result.as_object.reset(new GetMetaInfo::Results::Value::Object);
+
+ bookmark_api_helpers::GetMetaInfo(*node,
+ &result.as_object->additional_properties);
- const BookmarkNode::MetaInfoMap* meta_info = node->GetMetaInfoMap();
- if (meta_info)
- result.as_meta_info_fields->additional_properties = *meta_info;
results_ = GetMetaInfo::Results::Create(result);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698