Added option to bookmarkManagerPrivate.getMetaInfo() to get meta info from all bookmarks in a one f…

chrome/common/extensions/api/bookmark_manager_private.json

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 [
   {
     "namespace": "bookmarkManagerPrivate",
     "description": "none",
     "types": [
       {
@@ skipping 31 matching lines @@
             "type": "array",
             "items": {"$ref": "BookmarkNodeDataElement"}
           }
         }
       },
       {
         "id": "MetaInfoFields",
         "type": "object",
         "description": "Collection of meta info fields.",
         "additionalProperties": {"type": "string"}
+      },
+      {
+        "id": "MapMetaInfoFields",
+        "type": "object",
+        "description": "Map Id to MetaInfoFields.",
+        "additionalProperties": {"type": "any"}
       }
     ],
     "functions": [
       {
         "name": "copy",
         "type": "function",
         "description": "Copies the given bookmarks into the clipboard",
         "parameters": [
           {
             "name": "idList",
@@ skipping 200 matching lines @@
                 "$ref": "bookmarks.BookmarkTreeNode"
               }
             ]
           }
         ]
       },
       {
         "name": "getMetaInfo",
         "type": "function",
         "description": "Gets meta info from a bookmark node",
+        "allowAmbiguousOptionalArguments": true,
         "parameters": [
           {
             "name": "id",
-            "description": "The id of the bookmark to retrieve meta info from",
+            "description": "The id of the bookmark to retrieve meta info from. If ommited meta info for all nodes is returned.",

[Mike Wittman, 2014/06/16 17:47:35]

nit: omitted

[yefimt, 2014/06/16 19:04:01]

Done.

+            "optional": true,
             "type": "string"
           },
           {
             "name": "key",
             "description": "The key for the meta info to retrieve. If omitted, all fields are returned",
             "optional": true,
             "type": "string"
           },
           {
             "type": "function",
             "name": "callback",
             "parameters": [
               {
                 "name": "value",
                 "description": "If a key was given, the value of the specified field, if present. Otherwise an object containing all meta info fields for the node.",

[Mike Wittman, 2014/06/16 17:47:35]

update to describe new behavior

[yefimt, 2014/06/16 19:04:01]

Done.

                 "optional": true,
                 // TODO(rfevang): Convert this to always return MetaInfoFields

[Mike Wittman, 2014/06/16 17:47:35]

update or remove this comment?

[yefimt, 2014/06/16 19:04:01]

I think this comment is still valid.

                 // if the API is made public.
                 "choices": [
                   {"type": "string"},
-                  {"$ref": "MetaInfoFields"}
+                  {"$ref": "MetaInfoFields"},
+                  {"$ref": "MapMetaInfoFields"}
                 ]
               }
             ]
           }
         ]
       },
       {
         "name": "setMetaInfo",
         "type": "function",
         "description": "Sets a meta info value for a bookmark node",
@@ skipping 129 matching lines @@
         "type": "function",
         "description": "Fired when the meta info of a node changes.",
         "parameters": [
           {"name": "id", "type": "string"},
           {"name": "metaInfoChanges", "$ref": "MetaInfoFields"}
         ]
       }
     ]
   }
 ]