Add accessibility settings metrics

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
 
@@ skipping 478 matching lines @@
 
       // Accessibility section (CrOS only).
       if (cr.isChromeOS) {
         var updateAccessibilitySettingsButton = function() {
           $('accessibility-settings').hidden =
               !($('accessibility-spoken-feedback-check').checked);
         };
         Preferences.getInstance().addEventListener(
             'settings.accessibility',
             updateAccessibilitySettingsButton);
+        $('accessibility-learn-more').onclick = function(event) {

[michaelpg, 2014/06/13 22:05:05]

nit-ish: unused parameter

[stevenjb, 2014/06/13 22:11:01]

Hmm, pattern elsewhere seems to be to include the parameter even when unused.

[Dan Beam, 2014/06/16 19:08:24]

personal preference: no unused params
Super Official WebUI Reviewer Dude Opinion™: doesn't matter

[stevenjb, 2014/06/16 21:06:16]

I discussed this with some Blink developers and we basically agreed that either
kind of suck. (Unused variables are confusing, but apparently 'event' is
sometimes implicitly declared). We all thought that the C++-ish 'unused_event'
was a reasonable compromise, so I'll use that within this section and we can
make it consistent over time.

+          window.open(loadTimeData.getString('accessibilityLearnMoreURL'));
+          chrome.send('coreOptionsUserMetricsAction',
+                      ['Options_AccessibilityLearnMore']);
+        };
         $('accessibility-settings-button').onclick = function(event) {
           window.open(loadTimeData.getString('accessibilitySettingsURL'));
         };
         $('accessibility-spoken-feedback-check').onchange = function(event) {
           chrome.send('spokenFeedbackChange',
                       [$('accessibility-spoken-feedback-check').checked]);
           updateAccessibilitySettingsButton();
         };
         updateAccessibilitySettingsButton();
 
@@ skipping 1336 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });