Add accessibility settings metrics

Add accessibility settings metrics

BUG=370600
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278000

[stevenjb, 2014-06-13 21:45:25]

Options have been added to spreadsheet:
https://docs.google.com/a/google.com/spreadsheet/ccc?key=0AoaYRWUm3jbadE81NzN...

[michaelpg, 2014-06-13 22:05:05]

LGTM with a nit, remember to add a real owner :-)

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:499:
$('accessibility-learn-more').onclick = function(event) {
nit-ish: unused parameter

[stevenjb, 2014-06-13 22:11:01]

+dbeam@ for owner

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:499:
$('accessibility-learn-more').onclick = function(event) {
On 2014/06/13 22:05:05, Michael Giuffrida wrote:
> nit-ish: unused parameter
Hmm, pattern elsewhere seems to be to include the parameter even when unused.

[michaelpg, 2014-06-13 22:48:13]

On 2014/06/13 22:11:01, stevenjb wrote:
> +dbeam@ for owner
> 
>
https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
> File chrome/browser/resources/options/browser_options.js (right):
> 
>
https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
> chrome/browser/resources/options/browser_options.js:499:
> $('accessibility-learn-more').onclick = function(event) {
> On 2014/06/13 22:05:05, Michael Giuffrida wrote:
> > nit-ish: unused parameter
> Hmm, pattern elsewhere seems to be to include the parameter even when unused.

Yeah, it's not consistent but I guess including the parameter is more common.
dbeam@, preference?

[Dan Beam, 2014-06-16 19:08:24]

lgtm

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:718:
metric="Options_AccessibilitySystemMenu">
^ I assume these are already in the metrics system somehow?

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:499:
$('accessibility-learn-more').onclick = function(event) {
On 2014/06/13 22:11:01, stevenjb wrote:
> On 2014/06/13 22:05:05, Michael Giuffrida wrote:
> > nit-ish: unused parameter
> Hmm, pattern elsewhere seems to be to include the parameter even when unused.
> 

personal preference: no unused params
Super Official WebUI Reviewer Dude Opinion™: doesn't matter

[stevenjb, 2014-06-16 21:06:16]

+asvitkine@chromium.org for metrics owner

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:718:
metric="Options_AccessibilitySystemMenu">
On 2014/06/16 19:08:24, Dan Beam wrote:
> ^ I assume these are already in the metrics system somehow?
Doh. I missed the actions.xml changes on both these CLs. Will fix, thanks.

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/330953002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:499:
$('accessibility-learn-more').onclick = function(event) {
On 2014/06/16 19:08:24, Dan Beam wrote:
> On 2014/06/13 22:11:01, stevenjb wrote:
> > On 2014/06/13 22:05:05, Michael Giuffrida wrote:
> > > nit-ish: unused parameter
> > Hmm, pattern elsewhere seems to be to include the parameter even when
unused.
> > 
> 
> personal preference: no unused params
> Super Official WebUI Reviewer Dude Opinion™: doesn't matter
I discussed this with some Blink developers and we basically agreed that either
kind of suck. (Unused variables are confusing, but apparently 'event' is
sometimes implicitly declared). We all thought that the C++-ish 'unused_event'
was a reasonable compromise, so I'll use that within this section and we can
make it consistent over time.

[Alexei Svitkine (slow), 2014-06-16 21:20:39]

lgtm

[stevenjb, 2014-06-16 21:58:27]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-06-16 22:01:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/330953002/20001

[commit-bot: I haz the power, 2014-06-17 04:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 04:21:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[stevenjb, 2014-06-17 22:02:21]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-06-17 22:03:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stevenjb@chromium.org/330953002/40001

[commit-bot: I haz the power, 2014-06-18 09:51:36]

Change committed as 278000