Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 330913007: Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly (Closed)

Created:
6 years, 6 months ago by rhogan
Modified:
6 years, 6 months ago
Reviewers:
inferno
CC:
blink-reviews, blink-reviews-rendering, dsinclair, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho+blink_opera.com, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly (https://codereview.chromium.org/268833003/) Reason for revert: Causing clusterfuzz crashes BUG=388757 Original issue's description: > Refactor avoidsFloats() to reflect CSS2.1 spec more clearly > > Introduce the 'createsBlockFormatting' concept to RenderBlock::avoidsFloats() > and remove a couple of now-redundant virtualizations of the function. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173549 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176557 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M Source/core/rendering/RenderBlock.h View 3 chunks +4 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/core/rendering/RenderFieldset.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rhogan
Created Revert of Refactor avoidsFloats() to reflect CSS2.1 spec more clearly
6 years, 6 months ago (2014-06-25 17:20:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/330913007/1
6 years, 6 months ago (2014-06-25 17:21:49 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 17:21:51 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-25 17:21:51 UTC) #4
rhogan
lgtm
6 years, 6 months ago (2014-06-25 17:30:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-25 17:30:46 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-25 17:30:46 UTC) #7
rhogan
6 years, 6 months ago (2014-06-25 17:38:49 UTC) #8
inferno
lgtm
6 years, 6 months ago (2014-06-25 17:40:12 UTC) #9
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 6 months ago (2014-06-25 18:11:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/330913007/1
6 years, 6 months ago (2014-06-25 18:11:56 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-25 19:16:23 UTC) #12
Message was sent while issue was closed.
Change committed as 176943

Powered by Google App Engine
This is Rietveld 408576698