Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dart2js_incremental/lib/caching_compiler.dart

Issue 330913004: Move Compiler.libraries to LibraryLoader. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/compiler/implementation/library_loader.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dart2js_incremental/lib/caching_compiler.dart
diff --git a/pkg/dart2js_incremental/lib/caching_compiler.dart b/pkg/dart2js_incremental/lib/caching_compiler.dart
index 181f405e3782c877863ff2e997fbf49c3caba00e..caeec288f60b613bbcf57b936abd5a514d591745 100644
--- a/pkg/dart2js_incremental/lib/caching_compiler.dart
+++ b/pkg/dart2js_incremental/lib/caching_compiler.dart
@@ -130,15 +130,9 @@ Compiler reuseCompiler(
backend
..preMirrorsMethodCount = 0;
- Map libraries = new Map.from(compiler.libraries);
- compiler.libraries.clear();
- compiler.libraryLoader.reset();
- libraries.forEach((String uri, LibraryElement library) {
- if (library.isPlatformLibrary ||
- (packagesAreImmutable && library.isPackageLibrary)) {
- compiler.libraries[uri] = library;
- compiler.libraryLoader.reuseLibrary(library);
- }
+ compiler.libraryLoader.reset((LibraryElement library) {
ahe 2014/06/24 12:48:21 Sweet! PS: This file LGTM!
+ return library.isPlatformLibrary ||
+ (packagesAreImmutable && library.isPackageLibrary);
});
}
oldTag.makeCurrent();
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/compiler/implementation/library_loader.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698