Issue 330913004: Move Compiler.libraries to LibraryLoader.

Issue 330913004: Move Compiler.libraries to LibraryLoader. (Closed)

Created:
6 years, 6 months ago by Johnni Winther

Modified:
6 years, 6 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move Compiler.libraries to LibraryLoader. BUG= R=ahe@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=37659 Reverted: https://code.google.com/p/dart/source/detail?r=37663 Committed: https://code.google.com/p/dart/source/detail?r=37740

Patch Set 2 : Update cf. comments. #

Patch Set 4 : Fix compiler_isolate.dart #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -86 lines)			Patch
M	pkg/dart2js_incremental/lib/caching_compiler.dart	View	1	1 chunk	+3 lines, -9 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		6 chunks	+9 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/deferred_load.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dump_info.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View	1	5 chunks	+43 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors_used.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/use_unused_api.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	site/try/src/compiler_isolate.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_follow_constant_dependencies_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_follow_implicit_super_regression_test.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_load_graph_segmentation2_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/deferred_mirrors_test.dart	View		4 chunks	+13 lines, -9 lines	0 comments	Download
M	tests/compiler/dart2js/deferred_not_in_main_test.dart	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/in_user_code_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/memory_compiler.dart	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/metadata_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/mirrors_used_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/tag_mapping_test.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/330913004/diff/1/pkg/dart2js_incremental/lib/caching_compiler.dart File pkg/dart2js_incremental/lib/caching_compiler.dart (right): https://codereview.chromium.org/330913004/diff/1/pkg/dart2js_incremental/lib/caching_compiler.dart#newcode133 pkg/dart2js_incremental/lib/caching_compiler.dart:133: compiler.libraryLoader.reset((LibraryElement library) { Sweet! PS: This file LGTM!

6 years, 6 months ago (2014-06-24 12:48:21 UTC) #2

floitsch

LGTM. https://codereview.chromium.org/330913004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/330913004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode145 sdk/lib/_internal/compiler/implementation/library_loader.dart:145: void reset([bool reuseLibrary(LibraryElement library)]); I think it would ...

6 years, 6 months ago (2014-06-24 13:43:05 UTC) #3

Johnni Winther

https://codereview.chromium.org/330913004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/330913004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode145 sdk/lib/_internal/compiler/implementation/library_loader.dart:145: void reset([bool reuseLibrary(LibraryElement library)]); On 2014/06/24 13:43:05, floitsch wrote: ...

6 years, 6 months ago (2014-06-24 14:50:29 UTC) #4

Johnni Winther

Committed patchset #2 manually as r37659 (presubmit successful).

6 years, 6 months ago (2014-06-24 14:58:07 UTC) #5

ahe

https://codereview.chromium.org/330913004/diff/60001/pkg/dart2js_incremental/lib/caching_compiler.dart File pkg/dart2js_incremental/lib/caching_compiler.dart (right): https://codereview.chromium.org/330913004/diff/60001/pkg/dart2js_incremental/lib/caching_compiler.dart#newcode133 pkg/dart2js_incremental/lib/caching_compiler.dart:133: compiler.libraryLoader.reset(reuseLibrary: (LibraryElement library) { This file still LGTM

6 years, 6 months ago (2014-06-26 10:32:40 UTC) #7

Johnni Winther

6 years, 6 months ago (2014-06-26 13:11:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 manually as r37740 (presubmit successful).

Expand Messages | Collapse Messages