Revert of Include stlport through -isystem instead of -I.

Revert of Include stlport through -isystem instead of -I. (https://codereview.chromium.org/359783005/)

Reason for revert:
This patch breaks Android Goma builds (the build continues locally very slowly).

https://groups.google.com/a/google.com/forum/#!topic/goma-users/KNsshiobTvE


Original issue's description:
> Include stlport through -isystem instead of -I.
> 
> Enables removing a TODO and is needed for the bug linked below.
> 
> (Doesn't work for the webkit build for some reason, but that's currently
> not built with clang anyhow.)
> 
> BUG=381053
> TBR=brettw@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280406

TBR=cjhopman@chromium.org,thakis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381053
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280648

[Anton, 2014-06-30 17:05:50]

Created Revert of Include stlport through -isystem instead of -I.

[commit-bot: I haz the power, 2014-06-30 17:06:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anton@chromium.org/330873004/1

[commit-bot: I haz the power, 2014-06-30 17:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-30 17:06:20]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nico, 2014-06-30 17:28:30]

I was trying to say that reverting this doesn't lgtm as it'll break other
things.

How did you check that this is the cause of the slowdown?

(I filed https://b/15985218 for the goma thing, adding information there would
be good)

[Anton, 2014-06-30 17:41:21]

On 2014/06/30 17:28:30, Nico (away) wrote:
> I was trying to say that reverting this doesn't lgtm as it'll break other
> things.

I created this revert because you said "I suppose it's fine to revert the change
for a day or two if goma can be fixed
in that time".

Is there a particular try bot I should be running in order to verify that this
does not break other things.

> How did you check that this is the cause of the slowdown?

If you apply the revert, then the problem is fixed (0 FAILED in Goma).

> (I filed https://b/15985218 for the goma thing, adding information there would
> be good)

[Nico, 2014-06-30 17:52:16]

On Mon, Jun 30, 2014 at 10:41 AM, <anton@chromium.org> wrote:

> On 2014/06/30 17:28:30, Nico (away) wrote:
>
>> I was trying to say that reverting this doesn't lgtm as it'll break other
>> things.
>>
>
> I created this revert because you said "I suppose it's fine to revert the
> change
> for a day or two if goma can be fixed
> in that time".
>

With that I meant "it's ok to land that other change" (which was a revert
already)


> Is there a particular try bot I should be running in order to verify that
> this
> does not break other things.


It breaks building with trunk clang. There isn't a bot for that. (
http://crbug.com/381053)


>
>
>  How did you check that this is the cause of the slowdown?
>>
>
> If you apply the revert, then the problem is fixed (0 FAILED in Goma).


Aha, thanks. How do the FAILED lines look without it?


>
>
>  (I filed https://b/15985218 for the goma thing, adding information there
>> would
>> be good)
>>
>
>
> https://codereview.chromium.org/330873004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Anton, 2014-06-30 18:20:56]

On 2014/06/30 17:52:16, Nico (away) wrote:
> On Mon, Jun 30, 2014 at 10:41 AM, <mailto:anton@chromium.org> wrote:
> 
> > On 2014/06/30 17:28:30, Nico (away) wrote:
> >
> >> I was trying to say that reverting this doesn't lgtm as it'll break other
> >> things.
> >>
> >
> > I created this revert because you said "I suppose it's fine to revert the
> > change
> > for a day or two if goma can be fixed
> > in that time".
> >
> 
> With that I meant "it's ok to land that other change" (which was a revert
> already)
> 
> 
> > Is there a particular try bot I should be running in order to verify that
> > this
> > does not break other things.
> 
> 
> It breaks building with trunk clang. There isn't a bot for that. (
> http://crbug.com/381053)

Do you know that it was necessary to remove the -I to get the clang build to
work? Would just adding -isystem solve work.

> >
> >
> >  How did you check that this is the cause of the slowdown?
> >>
> >
> > If you apply the revert, then the problem is fixed (0 FAILED in Goma).
> 
> 
> Aha, thanks. How do the FAILED lines look without it?

In file included from
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_alloc.h:47:0,
from
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_string.h:23,
from
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/string:29,
from ../../third_party/webrtc/common_types.h:17,
from
../../third_party/webrtc/system_wrappers/interface/critical_section_wrapper.h:17,
from ../../third_party/webrtc/voice_engine/monitor_module.cc:11:
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_new.h:47:50:
fatal error: ../../gabi++/include/new: No such file or directory
# include _STLP_NATIVE_CPP_RUNTIME_HEADER(new)

> >
> >
> >  (I filed https://b/15985218 for the goma thing, adding information there
> >> would
> >> be good)
> >>
> >
> >
> > https://codereview.chromium.org/330873004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-06-30 18:23:44]

On 2014/06/30 18:20:56, Anton wrote:
> On 2014/06/30 17:52:16, Nico (away) wrote:
> > On Mon, Jun 30, 2014 at 10:41 AM, <mailto:anton@chromium.org> wrote:
> > 
> > > On 2014/06/30 17:28:30, Nico (away) wrote:
> > >
> > >> I was trying to say that reverting this doesn't lgtm as it'll break other
> > >> things.
> > >>
> > >
> > > I created this revert because you said "I suppose it's fine to revert the
> > > change
> > > for a day or two if goma can be fixed
> > > in that time".
> > >
> > 
> > With that I meant "it's ok to land that other change" (which was a revert
> > already)
> > 
> > 
> > > Is there a particular try bot I should be running in order to verify that
> > > this
> > > does not break other things.
> > 
> > 
> > It breaks building with trunk clang. There isn't a bot for that. (
> > http://crbug.com/381053)
> 
> Do you know that it was necessary to remove the -I to get the clang build to
> work? Would just adding -isystem solve work.

-I and -isystem are the same flag, except that the latter marks the headers in
the directory as "system headers", and clang suppresses some diagnostics in
system headers.

> > >
> > >
> > >  How did you check that this is the cause of the slowdown?
> > >>
> > >
> > > If you apply the revert, then the problem is fixed (0 FAILED in Goma).
> > 
> > 
> > Aha, thanks. How do the FAILED lines look without it?
> 
> In file included from
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_alloc.h:47:0,
> from
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_string.h:23,
> from
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/string:29,
> from ../../third_party/webrtc/common_types.h:17,
> from
>
../../third_party/webrtc/system_wrappers/interface/critical_section_wrapper.h:17,
> from ../../third_party/webrtc/voice_engine/monitor_module.cc:11:
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_new.h:47:50:
> fatal error: ../../gabi++/include/new: No such file or directory
> # include _STLP_NATIVE_CPP_RUNTIME_HEADER(new)

Huh. Are you sure this is related to goma? Do you see this if you disable goma
too?

> 
> > >
> > >
> > >  (I filed https://b/15985218 for the goma thing, adding information there
> > >> would
> > >> be good)
> > >>
> > >
> > >
> > > https://codereview.chromium.org/330873004/
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-06-30 19:51:29]

lgtm, let's land this for now

[Nico, 2014-06-30 19:51:33]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-06-30 19:52:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anton@chromium.org/330873004/1

[commit-bot: I haz the power, 2014-06-30 19:53:46]

Change committed as 280648

[Anton, 2014-07-01 09:37:07]

On 2014/06/30 18:23:44, Nico (away) wrote:
> On 2014/06/30 18:20:56, Anton wrote:
> > On 2014/06/30 17:52:16, Nico (away) wrote:
> > > On Mon, Jun 30, 2014 at 10:41 AM, <mailto:anton@chromium.org> wrote:
> > > 
> > > > On 2014/06/30 17:28:30, Nico (away) wrote:
> > > >
> > > >> I was trying to say that reverting this doesn't lgtm as it'll break
other
> > > >> things.
> > > >>
> > > >
> > > > I created this revert because you said "I suppose it's fine to revert
the
> > > > change
> > > > for a day or two if goma can be fixed
> > > > in that time".
> > > >
> > > 
> > > With that I meant "it's ok to land that other change" (which was a revert
> > > already)
> > > 
> > > 
> > > > Is there a particular try bot I should be running in order to verify
that
> > > > this
> > > > does not break other things.
> > > 
> > > 
> > > It breaks building with trunk clang. There isn't a bot for that. (
> > > http://crbug.com/381053)
> > 
> > Do you know that it was necessary to remove the -I to get the clang build to
> > work? Would just adding -isystem solve work.
> 
> -I and -isystem are the same flag, except that the latter marks the headers in
> the directory as "system headers", and clang suppresses some diagnostics in
> system headers.
> 
> > > >
> > > >
> > > >  How did you check that this is the cause of the slowdown?
> > > >>
> > > >
> > > > If you apply the revert, then the problem is fixed (0 FAILED in Goma).
> > > 
> > > 
> > > Aha, thanks. How do the FAILED lines look without it?
> > 
> > In file included from
> >
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_alloc.h:47:0,
> > from
> >
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_string.h:23,
> > from
> >
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/string:29,
> > from ../../third_party/webrtc/common_types.h:17,
> > from
> >
>
../../third_party/webrtc/system_wrappers/interface/critical_section_wrapper.h:17,
> > from ../../third_party/webrtc/voice_engine/monitor_module.cc:11:
> >
>
/usr/local/google/code/clankium/src/third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport/stl/_new.h:47:50:
> > fatal error: ../../gabi++/include/new: No such file or directory
> > # include _STLP_NATIVE_CPP_RUNTIME_HEADER(new)
> 
> Huh. Are you sure this is related to goma? Do you see this if you disable goma
> too?

This error only happens on Goma.