Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/browser/themes/theme_service_aurax11.cc

Issue 330873003: Fix first time switching from classic to GTK theme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_service_aurax11.cc
diff --git a/chrome/browser/themes/theme_service_aurax11.cc b/chrome/browser/themes/theme_service_aurax11.cc
index 95a834ca24efa1bab2418da2ea3a305d7d34df11..8eb13ed8847f98ba52dd63ab98670acfdb0958b2 100644
--- a/chrome/browser/themes/theme_service_aurax11.cc
+++ b/chrome/browser/themes/theme_service_aurax11.cc
@@ -43,13 +43,16 @@ SystemThemeX11::SystemThemeX11(PrefService* pref_service)
void SystemThemeX11::StartUsingTheme() {
pref_service_->SetBoolean(prefs::kUsesSystemTheme, true);
- // Have the former theme notify its observers of change.
+ // Both old and new themes' observers should be notified of the change.
Elliot Glaysher 2014/06/13 20:05:54 Could you please expand this comment to include mo
Evan Stade 2014/06/13 20:14:39 Done.
+ if (linux_ui_)
+ linux_ui_->GetNativeTheme(NULL)->NotifyObservers();
ui::NativeThemeAura::instance()->NotifyObservers();
}
void SystemThemeX11::StopUsingTheme() {
pref_service_->SetBoolean(prefs::kUsesSystemTheme, false);
- // Have the former theme notify its observers of change.
+ // Both old and new themes' observers should be notified of the change.
+ ui::NativeThemeAura::instance()->NotifyObservers();
if (linux_ui_)
linux_ui_->GetNativeTheme(NULL)->NotifyObservers();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698