Make the policy fetch for first time login blocking

chrome/browser/chromeos/login/login_utils_browsertest.cc

Index: chrome/browser/chromeos/login/login_utils_browsertest.cc
diff --git a/chrome/browser/chromeos/login/login_utils_browsertest.cc b/chrome/browser/chromeos/login/login_utils_browsertest.cc
index 4437e5352d412e8ee4a6aad21172b1f923bd4f9e..753a64bec5ade258a9972be8d2db7fbdc8d833a6 100644
--- a/chrome/browser/chromeos/login/login_utils_browsertest.cc
+++ b/chrome/browser/chromeos/login/login_utils_browsertest.cc
@@ -532,7 +532,7 @@ class LoginUtilsBlockingLoginTest
     : public LoginUtilsTest,
       public testing::WithParamInterface<int> {};
 
-TEST_F(LoginUtilsTest, NormalLoginDoesntBlock) {
+TEST_F(LoginUtilsTest, NormalLoginDoesBlock) {
   UserManager* user_manager = UserManager::Get();
   EXPECT_FALSE(user_manager->IsUserLoggedIn());
   EXPECT_FALSE(connector_->IsEnterpriseManaged());
@@ -543,12 +543,10 @@ TEST_F(LoginUtilsTest, NormalLoginDoesntBlock) {
   // The profile will be created without waiting for a policy response.
   PrepareProfile(kUsername);
 
-  EXPECT_TRUE(prepared_profile_);
-  ASSERT_TRUE(user_manager->IsUserLoggedIn());
-  EXPECT_EQ(kUsername, user_manager->GetLoggedInUser()->email());
+  EXPECT_FALSE(prepared_profile_);

[Nikita (slow), 2014/07/08 15:08:30]

Why profile will be NULL here?

[kaliamoorthi, 2014/07/08 15:44:34]

I have made the first login block on policy fetch for all users. So
PrepareProfile returns immediately without OnProfilePrepared being called. The
profile is set to a non NULL value by OnProfilePrepared, which will eventually
get called after blocking policy fetch completes. It the mean time it remains
null.

 }
 
-TEST_F(LoginUtilsTest, EnterpriseLoginDoesntBlockForNormalUser) {
+TEST_F(LoginUtilsTest, EnterpriseLoginDoesBlockForNormalUser) {
   UserManager* user_manager = UserManager::Get();
   EXPECT_FALSE(user_manager->IsUserLoggedIn());
   EXPECT_FALSE(connector_->IsEnterpriseManaged());
@@ -567,9 +565,7 @@ TEST_F(LoginUtilsTest, EnterpriseLoginDoesntBlockForNormalUser) {
   // Login with a non-enterprise user shouldn't block.
   PrepareProfile(kUsernameOtherDomain);
 
-  EXPECT_TRUE(prepared_profile_);
-  ASSERT_TRUE(user_manager->IsUserLoggedIn());
-  EXPECT_EQ(kUsernameOtherDomain, user_manager->GetLoggedInUser()->email());
+  EXPECT_FALSE(prepared_profile_);
 }
 
 #if defined(ENABLE_RLZ)