Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: chromeos/dbus/shill_service_client.h

Issue 330833003: Rely on Service.Visible instead of Manager.Services (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix stubs for tests Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_manager_client.h ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_service_client.h
diff --git a/chromeos/dbus/shill_service_client.h b/chromeos/dbus/shill_service_client.h
index 40507fea8b7be2d99111b04d6f888ea690720058..e8b950fd5fc6eca506927caaf1f5f399f3318055 100644
--- a/chromeos/dbus/shill_service_client.h
+++ b/chromeos/dbus/shill_service_client.h
@@ -48,14 +48,23 @@ class CHROMEOS_EXPORT ShillServiceClient : public DBusClient {
const std::string& name,
const std::string& type,
const std::string& state,
- bool add_to_visible_list) = 0;
+ bool visible) = 0;
virtual void AddServiceWithIPConfig(const std::string& service_path,
const std::string& guid,
const std::string& name,
const std::string& type,
const std::string& state,
const std::string& ipconfig_path,
- bool add_to_visible_list) = 0;
+ bool visible) = 0;
+ // Sets the properties for a service but does not add it to the Manager
+ // or Profile. Returns the properties for the service.
+ virtual base::DictionaryValue* SetServiceProperties(
+ const std::string& service_path,
+ const std::string& guid,
+ const std::string& name,
+ const std::string& type,
+ const std::string& state,
+ bool visible) = 0;
// Removes a Service to the Manager and Service stubs.
virtual void RemoveService(const std::string& service_path) = 0;
« no previous file with comments | « chromeos/dbus/shill_manager_client.h ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698