Rely on Service.Visible instead of Manager.Services

chromeos/network/network_state_handler.h

Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 2d2914b2a91ba8454ae1192d395ced6419b5a217..c017f460828e3eeb7eef0347de61060a397d0462 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -244,11 +244,6 @@ class CHROMEOS_EXPORT NetworkStateHandler
   virtual void UpdateManagedList(ManagedState::ManagedType type,
                                  const base::ListValue& entries) OVERRIDE;
 
-  // Updates the visibility of entries in |network_list_|. This should not
-  // contain entries that are not in |network_list_|. Any such entries will be
-  // ignored with an error message.
-  virtual void UpdateVisibleNetworks(const base::ListValue& entries) OVERRIDE;
-
   // The list of profiles changed (i.e. a user has logged in). Re-request
   // properties for all services since they may have changed.
   virtual void ProfileListChanged() OVERRIDE;
@@ -311,6 +306,9 @@ class CHROMEOS_EXPORT NetworkStateHandler
   friend class NetworkStateHandlerTest;
   FRIEND_TEST_ALL_PREFIXES(NetworkStateHandlerTest, NetworkStateHandlerStub);
 
+  // Sort the network list and update UMA stats.

[pneubeck (no reviews), 2014/06/16 14:38:15]

Maybe either add a comment that this is only ever called if every NetworkState
has received properties before, or handle states with !update_received()
explicitly in the implementation.

[stevenjb, 2014/06/16 19:54:49]

This is called directly by ManagedStateListChanged, which already has a comment
to that effect.

+  void UpdateNetworkList();
+
   // NetworkState specific method for UpdateManagedStateProperties which
   // notifies observers.
   void UpdateNetworkStateProperties(NetworkState* network,