Rely on Service.Visible instead of Manager.Services

chromeos/dbus/fake_shill_manager_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_
 #define CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 90 matching lines @@
   virtual void SortManagerServices(bool notify) OVERRIDE;
   virtual void SetupDefaultEnvironment() OVERRIDE;
   virtual int GetInteractiveDelay() const OVERRIDE;
   virtual void SetBestServiceToConnect(
       const std::string& service_path) OVERRIDE;
 
   // Constants used for testing.
   static const char kFakeEthernetNetworkPath[];
 
  private:
-  // |property| should be kServicesProperty or kServiceCompleteListProperty.
   void SortServiceList(const std::string& property);

[pneubeck (no reviews), 2014/06/16 14:38:15]

oops. This function isn't defined (and is unused). Somehow we missed it before.

[stevenjb, 2014/06/16 19:54:49]

Done.

 
   void SetDefaultProperties();
   void PassStubProperties(const DictionaryValueCallback& callback) const;
   void PassStubGeoNetworks(const DictionaryValueCallback& callback) const;
   void CallNotifyObserversPropertyChanged(const std::string& property);
   void NotifyObserversPropertyChanged(const std::string& property);
   base::ListValue* GetListProperty(const std::string& property);
   bool TechnologyEnabled(const std::string& type) const;
   void SetTechnologyEnabled(const std::string& type,
                             const base::Closure& callback,
@@ skipping 34 matching lines @@
 
   // 'Best' service to connect to on ConnectToBestServices() calls.
   std::string best_service_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeShillManagerClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_FAKE_SHILL_MANAGER_CLIENT_H_