Source/platform/graphics/Color.cpp - Issue 330823006: Define Color::transparent et al. when using Clang on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/Color.cpp

Issue 330823006: Define Color::transparent et al. when using Clang on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Just fix it locally Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/graphics/Color.cpp

diff --git a/Source/platform/graphics/Color.cpp b/Source/platform/graphics/Color.cpp

index 3c0b7429750012fd7d9ff5b98a511972a5c3900d..db081a70a37e57d0b72a9579c33f2c838fdc3904 100644

--- a/Source/platform/graphics/Color.cpp

+++ b/Source/platform/graphics/Color.cpp

@@ -37,7 +37,8 @@ using namespace std;

namespace WebCore {

-#if !COMPILER(MSVC)

+#if !COMPILER(MSVC) || COMPILER(CLANG)

+// FIXME: Use C++11 strong enums to avoid static data member with initializer definition problems.

const RGBA32 Color::black;

const RGBA32 Color::white;

const RGBA32 Color::darkGray;

« no previous file with comments | « no previous file | no next file » | no next file with comments »