Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 330763008: Add R11 EAC pixel config (Closed)

Created:
6 years, 5 months ago by krajcevski
Modified:
6 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

R11 EAC texture compression is introduced as part of the OpenGL ES 3.0 spec. This is a format that will likely be required on most mobile phones in the upcoming years, making it better to target than LATC, which is only available on NVIDIA GPUs. Committed: https://skia.googlesource.com/skia/+/238b456a7c6fb85c15f1ec288ea4f406a1a89da2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ES3 compatibility check #

Patch Set 3 : Finding the size should be easy to do #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M include/gpu/GrColor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M include/gpu/GrTypes.h View 4 chunks +10 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
krajcevski
6 years, 5 months ago (2014-06-27 16:41:23 UTC) #1
robertphillips
lgtm + a question Maybe add a snippet in the description about why this is ...
6 years, 5 months ago (2014-06-27 16:56:47 UTC) #2
krajcevski
https://codereview.chromium.org/330763008/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/330763008/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode535 src/gpu/gl/GrGLCaps.cpp:535: // Check for R11_EAC On 2014/06/27 16:56:47, robertphillips wrote: ...
6 years, 5 months ago (2014-06-27 17:49:37 UTC) #3
bsalomon
lgtm
6 years, 5 months ago (2014-06-30 15:46:27 UTC) #4
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 5 months ago (2014-06-30 15:46:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/330763008/40001
6 years, 5 months ago (2014-06-30 15:47:27 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 16:09:26 UTC) #7
Message was sent while issue was closed.
Change committed as 238b456a7c6fb85c15f1ec288ea4f406a1a89da2

Powered by Google App Engine
This is Rietveld 408576698