[cros touch] Proper handling of non-maximized/fullscreen windows in lock screen container

[cros touch] Proper handling of non-maximized/fullscreen windows in lock screen container

Switch cros login host window back to ui::SHOW_STATE_FULLSCREEN since new layout manager handles that correctly even with virtual keyboard.
This way login window state will be consistent with screen lock state which is full screen.

BUG=384849
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278691

[oshima, 2014-06-19 20:50:01]

lg with one question in the test

https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:58: };
It looks to me that this is same as default widget delegate, am I wrong?

[Nikita (slow), 2014-06-20 03:45:45]

https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:58: };
On 2014/06/19 20:50:01, oshima wrote:
> It looks to me that this is same as default widget delegate, am I wrong?

Yes, but it has to be explicitly set for TYPE_WINDOW_FRAMELESS / 
ui::SHOW_STATE_MAXIMIZED though.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...

if (RequiresNonClientView(params.type)) {
  ..
} else if (params.delegate) {
  SetContentsView(params.delegate->GetContentsView());
  SetInitialBoundsForFramelessWindow(params.bounds);
}

otherwise else part won't get called.

[Nikita (slow), 2014-06-20 03:48:27]

On 2014/06/20 03:45:45, Nikita Kostylev wrote:
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> File ash/wm/lock_layout_manager_unittest.cc (right):
> 
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> ash/wm/lock_layout_manager_unittest.cc:58: };
> On 2014/06/19 20:50:01, oshima wrote:
> > It looks to me that this is same as default widget delegate, am I wrong?
> 
> Yes, but it has to be explicitly set for TYPE_WINDOW_FRAMELESS / 
> ui::SHOW_STATE_MAXIMIZED though.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...
> 
> if (RequiresNonClientView(params.type)) {
>   ..
> } else if (params.delegate) {
>   SetContentsView(params.delegate->GetContentsView());
>   SetInitialBoundsForFramelessWindow(params.bounds);
> }
> 
> otherwise else part won't get called.

Specifically SetInitialBoundsForFramelessWindow(params.bounds) is important.

[oshima, 2014-06-20 04:55:18]

On 2014/06/20 03:48:27, Nikita Kostylev wrote:
> On 2014/06/20 03:45:45, Nikita Kostylev wrote:
> >
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> > File ash/wm/lock_layout_manager_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> > ash/wm/lock_layout_manager_unittest.cc:58: };
> > On 2014/06/19 20:50:01, oshima wrote:
> > > It looks to me that this is same as default widget delegate, am I wrong?
> > 
> > Yes, but it has to be explicitly set for TYPE_WINDOW_FRAMELESS / 
> > ui::SHOW_STATE_MAXIMIZED though.
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...
> > 
> > if (RequiresNonClientView(params.type)) {
> >   ..
> > } else if (params.delegate) {
> >   SetContentsView(params.delegate->GetContentsView());
> >   SetInitialBoundsForFramelessWindow(params.bounds);
> > }
> > 
> > otherwise else part won't get called.
> 
> Specifically SetInitialBoundsForFramelessWindow(params.bounds) is important.

hmm, maybe it should set the initial bounds anyway, but ok, this CL lgtm.

[Nikita (slow), 2014-06-20 07:25:36]

On 2014/06/20 04:55:18, oshima wrote:
> On 2014/06/20 03:48:27, Nikita Kostylev wrote:
> > On 2014/06/20 03:45:45, Nikita Kostylev wrote:
> > >
> >
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> > > File ash/wm/lock_layout_manager_unittest.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/330763005/diff/20001/ash/wm/lock_layout_manag...
> > > ash/wm/lock_layout_manager_unittest.cc:58: };
> > > On 2014/06/19 20:50:01, oshima wrote:
> > > > It looks to me that this is same as default widget delegate, am I wrong?
> > > 
> > > Yes, but it has to be explicitly set for TYPE_WINDOW_FRAMELESS / 
> > > ui::SHOW_STATE_MAXIMIZED though.
> > > 
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/widget/wi...
> > > 
> > > if (RequiresNonClientView(params.type)) {
> > >   ..
> > > } else if (params.delegate) {
> > >   SetContentsView(params.delegate->GetContentsView());
> > >   SetInitialBoundsForFramelessWindow(params.bounds);
> > > }
> > > 
> > > otherwise else part won't get called.
> > 
> > Specifically SetInitialBoundsForFramelessWindow(params.bounds) is important.
> 
> hmm, maybe it should set the initial bounds anyway, but ok, this CL lgtm.

I agree, it seems that SetInitialBoundsForFramelessWindow(params.bounds) should
taken out of that else block.
But I don't know whether this will break anything or not. I guess it shouldn't.

[Nikita (slow), 2014-06-20 07:27:27]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-06-20 07:28:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nkostylev@chromium.org/330763005/40001

[commit-bot: I haz the power, 2014-06-20 13:07:12]

Change committed as 278691