Browser and unit tests for the SB interstitial V3

chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index a4af0449ca6b7951f2f1379c84baf3ce5f68a6cd..76a83c8d35efdf26bd0cbf4a105618db9691c829 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -158,24 +158,6 @@ bool Version3Enabled() {
   return false;
 }
 
-class SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
- public:
-  SafeBrowsingBlockingPageV3(SafeBrowsingUIManager* ui_manager,
-                             content::WebContents* web_contents,
-                             const UnsafeResourceList& unsafe_resources);
-
-  // InterstitialPageDelegate method:
-  virtual std::string GetHTMLContents() OVERRIDE;
-
- private:
-  // Fills the passed dictionary with the values to be passed to the template
-  // when creating the HTML.
-  void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);
-  void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);
-
-  DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV3);
-};
-
 }  // namespace
 
 // static
@@ -499,16 +481,21 @@ void SafeBrowsingBlockingPage::SetReportingPreference(bool report) {
 // kSafeBrowsingExtendedReportingEnabled should be updated.
 // TODO(felt): Remove this in M-39. crbug.com/384668
 void SafeBrowsingBlockingPage::UpdateReportingPref() {
+  LOG(ERROR) << "1";
   if (!reporting_checkbox_checked_)
     return;
+  LOG(ERROR) << "2";
   if (IsPrefEnabled(prefs::kSafeBrowsingExtendedReportingEnabled))
     return;
+  LOG(ERROR) << "3";
   Profile* profile = Profile::FromBrowserContext(
       web_contents_->GetBrowserContext());
   if (profile->GetPrefs()->HasPrefPath(
       prefs::kSafeBrowsingExtendedReportingEnabled))
     return;
+  LOG(ERROR) << "4";
   SetReportingPreference(true);
+  LOG(ERROR) << "5";

[mattm, 2014/06/17 18:38:48]

looks like some debug logging snuck in before this was committed

[felt, 2014/06/17 18:42:25]

pls review fix: https://codereview.chromium.org/338653004/

 }
 
 void SafeBrowsingBlockingPage::OnProceed() {