chrome/browser/services/gcm/gcm_desktop_utils.cc - Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/gcm_desktop_utils.cc

Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browser_process_impl.cc ('K') | « chrome/browser/services/gcm/gcm_desktop_utils.h ('k') | chrome/browser/services/gcm/gcm_profile_service.h » ('j') | chrome/browser/services/gcm/gcm_profile_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/gcm_desktop_utils.cc

diff --git a/chrome/browser/services/gcm/gcm_desktop_utils.cc b/chrome/browser/services/gcm/gcm_desktop_utils.cc

index 05ed2f810c5f15ae8c38ed8d1e66252740a7205e..7e81c8dd9646cb76e34ca32c8e1645a89879e556 100644

--- a/chrome/browser/services/gcm/gcm_desktop_utils.cc

+++ b/chrome/browser/services/gcm/gcm_desktop_utils.cc

@@ -73,7 +73,6 @@ GCMClient::ChromeBuildInfo GetChromeBuildInfo() {

scoped_ptr<GCMDriver> CreateGCMDriverDesktop(

scoped_ptr<GCMClientFactory> gcm_client_factory,

- scoped_ptr<IdentityProvider> identity_provider,

const base::FilePath& store_path,

const scoped_refptr<net::URLRequestContextGetter>& request_context) {

scoped_refptr<base::SequencedWorkerPool> worker_pool(

@@ -84,7 +83,6 @@ scoped_ptr<GCMDriver> CreateGCMDriverDesktop(

base::SequencedWorkerPool::SKIP_ON_SHUTDOWN));

return scoped_ptr<GCMDriver>(new GCMDriverDesktop(

gcm_client_factory.Pass(),

- identity_provider.Pass(),

GetChromeBuildInfo(),

store_path,

request_context,