Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: components/gcm_driver/gcm_driver_desktop.h

Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix after sync Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_android.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.h
diff --git a/components/gcm_driver/gcm_driver_desktop.h b/components/gcm_driver/gcm_driver_desktop.h
index 8987a29c71119cae90bad6ac49a3efd1871c400a..0ddf5e31efea41a337a11891462e2866836897df 100644
--- a/components/gcm_driver/gcm_driver_desktop.h
+++ b/components/gcm_driver/gcm_driver_desktop.h
@@ -16,7 +16,6 @@
#include "base/memory/weak_ptr.h"
#include "components/gcm_driver/gcm_client.h"
#include "components/gcm_driver/gcm_driver.h"
-#include "google_apis/gaia/identity_provider.h"
namespace base {
class FilePath;
@@ -37,11 +36,10 @@ class GCMAppHandler;
class GCMClientFactory;
// GCMDriver implementation for desktop and Chrome OS, using GCMClient.
-class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
+class GCMDriverDesktop : public GCMDriver {
public:
GCMDriverDesktop(
scoped_ptr<GCMClientFactory> gcm_client_factory,
- scoped_ptr<IdentityProvider> identity_provider,
const GCMClient::ChromeBuildInfo& chrome_build_info,
const base::FilePath& store_path,
const scoped_refptr<net::URLRequestContextGetter>& request_context,
@@ -50,12 +48,10 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner);
virtual ~GCMDriverDesktop();
- // IdentityProvider::Observer implementation:
- virtual void OnActiveAccountLogin() OVERRIDE;
- virtual void OnActiveAccountLogout() OVERRIDE;
-
// GCMDriver overrides:
virtual void Shutdown() OVERRIDE;
+ virtual void OnSignedIn() OVERRIDE;
+ virtual void Purge() OVERRIDE;
virtual void AddAppHandler(const std::string& app_id,
GCMAppHandler* handler) OVERRIDE;
virtual void RemoveAppHandler(const std::string& app_id) OVERRIDE;
@@ -71,7 +67,6 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
bool clear_logs) OVERRIDE;
virtual void SetGCMRecording(const GetGCMStatisticsCallback& callback,
bool recording) OVERRIDE;
- virtual std::string SignedInUserName() const OVERRIDE;
protected:
// GCMDriver implementation:
@@ -94,9 +89,6 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
// Remove cached data when GCM service is stopped.
void RemoveCachedData();
- // Checks out of GCM and erases any cached and persisted data.
- void CheckOut();
-
void DoRegister(const std::string& app_id,
const std::vector<std::string>& sender_ids);
void DoUnregister(const std::string& app_id);
@@ -116,6 +108,13 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
void GetGCMStatisticsFinished(const GCMClient::GCMStatistics& stats);
+ // Flag to indicate whether the user is signed in to a GAIA account.
+ // TODO(jianli): To be removed when sign-in enforcement is dropped.
+ bool signed_in_;
+
+ // Flag to indicate if GCM is started.
+ bool gcm_started_;
+
// Flag to indicate if GCM is enabled.
bool gcm_enabled_;
@@ -127,11 +126,6 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
// it may be out of date while connection changes are happening.
bool connected_;
- // The account ID that this service is responsible for. Empty when the service
- // is not running.
- std::string account_id_;
-
- scoped_ptr<IdentityProvider> identity_provider_;
scoped_refptr<base::SequencedTaskRunner> ui_thread_;
scoped_refptr<base::SequencedTaskRunner> io_thread_;
« no previous file with comments | « components/gcm_driver/gcm_driver_android.cc ('k') | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698