Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5129)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix after sync Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_desktop_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index eac76f225baa1690f8bfee685b82f13e13172e3a..4d391b735ca9f1f0f9ad2838bfc3373225f3d957 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -91,7 +91,6 @@
#include "content/public/browser/storage_partition.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension_l10n_util.h"
-#include "google_apis/gaia/identity_provider.h"
#include "net/socket/client_socket_pool_manager.h"
#include "net/url_request/url_request_context_getter.h"
#include "ui/base/l10n/l10n_util.h"
@@ -127,13 +126,6 @@
#include "chrome/browser/media/webrtc_log_uploader.h"
#endif
-#if defined(OS_CHROMEOS)
-#include "chrome/browser/chromeos/settings/device_identity_provider.h"
-#include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
-#elif !defined(OS_ANDROID)
-#include "google_apis/gaia/dummy_identity_provider.h"
-#endif
-
#if defined(OS_ANDROID)
#include "components/gcm_driver/gcm_driver_android.h"
#else
@@ -1023,14 +1015,13 @@ void BrowserProcessImpl::CreateGCMDriver() {
CHECK(PathService::Get(chrome::DIR_GLOBAL_GCM_STORE, &store_path));
gcm_driver_ = gcm::CreateGCMDriverDesktop(
make_scoped_ptr(new gcm::GCMClientFactory),
-#if defined(OS_CHROMEOS)
- scoped_ptr<IdentityProvider>(new chromeos::DeviceIdentityProvider(
- chromeos::DeviceOAuth2TokenServiceFactory::Get())),
-#else
- scoped_ptr<IdentityProvider>(new DummyIdentityProvider),
-#endif // defined(OS_CHROMEOS)
store_path,
system_request_context());
+ // Sign-in is not required for device-level GCM usage. So we just call
+ // OnSignedIn to assume always signed-in. Note that GCM will not be started
+ // at this point since no one has asked for it yet.
+ // TODO(jianli): To be removed when sign-in enforcement is dropped.
+ gcm_driver_->OnSignedIn();
#endif // defined(OS_ANDROID)
}
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_desktop_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698