Update SelectorQuery constructor to adopt CSSSelectorList object

Update SelectorQuery constructor to adopt CSSSelectorList object

Update SelectorQuery constructor to adopt CSSSelectorList object instead of
copying it. This CL adds a adopt(CSSSelectorList&) factory function to
SelectorQuery class to make this behavior obvious.

Copying a CSSSelectorList is relatively expensive and it should therefore be
avoided when possible.

R=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176116

[esprehn, 2014-06-13 03:47:41]

lgtm, but please fix the name first.

https://codereview.chromium.org/330713003/diff/1/Source/core/dom/SelectorQuer...
File Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/330713003/diff/1/Source/core/dom/SelectorQuer...
Source/core/dom/SelectorQuery.cpp:468: PassOwnPtr<SelectorQuery>
SelectorQuery::createAndAdopt(CSSSelectorList& selectorList)
Just ::adopt(), that's what we use for NodeLists too.

[Inactive, 2014-06-13 12:25:27]

https://codereview.chromium.org/330713003/diff/1/Source/core/dom/SelectorQuer...
File Source/core/dom/SelectorQuery.cpp (right):

https://codereview.chromium.org/330713003/diff/1/Source/core/dom/SelectorQuer...
Source/core/dom/SelectorQuery.cpp:468: PassOwnPtr<SelectorQuery>
SelectorQuery::createAndAdopt(CSSSelectorList& selectorList)
On 2014/06/13 03:47:41, esprehn wrote:
> Just ::adopt(), that's what we use for NodeLists too.

Right, I missed that StaticNodeList was using adopt() naming. It is good to be
consistent indeed. I made the change.

[Inactive, 2014-06-13 12:25:30]

The CQ bit was checked by ch.dumez@samsung.com

[Inactive, 2014-06-13 12:25:38]

The CQ bit was unchecked by ch.dumez@samsung.com

[Inactive, 2014-06-13 12:25:59]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-13 12:26:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/330713003/20001

[commit-bot: I haz the power, 2014-06-13 13:39:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-13 14:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 14:33:05]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Inactive, 2014-06-13 14:35:18]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-13 14:36:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/330713003/20001

[commit-bot: I haz the power, 2014-06-13 15:44:19]

Change committed as 176116