Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 330703004: Don't check OFFICIAL_BUILD for 'Chrome' decision in breakpad (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Don't check OFFICIAL_BUILD for 'Chrome' decision in breakpad Should just be GOOGLE_CHROME_BUILD, not related to optimization level. R=cpu@chromium.org BUG=383902 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/chrome_breakpad_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 6 months ago (2014-06-12 20:52:58 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-12 22:39:05 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-12 22:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/330703004/1
6 years, 6 months ago (2014-06-12 22:58:19 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 04:09:03 UTC) #5
Message was sent while issue was closed.
Change committed as 276920

Powered by Google App Engine
This is Rietveld 408576698