Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 330653006: Include the latest binary download info in safe browsing incident reports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: attempt to fix gn build Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cee3bd4ed06b161e7253c1f46a1898a1d0ecdb4b..d654fe39fb5aed1faf718df837a6fe577eed8cab 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -26080,6 +26080,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="SBIRS.FindDownloadedBinaryTime" units="milliseconds">
+ <owner>grt@google.com</owner>
+ <summary>
+ The elapsed time to find the most recent binary download from all loaded
+ profiles when creating a safe browsing incident report.
+ </summary>
+</histogram>
+
<histogram name="SBIRS.Incident" enum="IncidentType">
<owner>grt@google.com</owner>
<summary>
@@ -26121,11 +26129,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<summary>The elapsed time to upload a safe browsing incident report.</summary>
</histogram>
-<histogram name="SBIRS.UploadResult" enum="UploadResult">
+<histogram name="SBIRS.UploadResult" enum="ReportProcessingResult">
<owner>grt@google.com</owner>
<summary>
- The result of a report upload by the safe browsing incident reporting
- service.
+ The result of an attempted report upload by the safe browsing incident
+ reporting service.
</summary>
</histogram>
@@ -45001,6 +45009,26 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="58" label="IDC_SPELLCHECK_SUGGESTION"/>
</enum>
+<enum name="ReportProcessingResult" type="int">
+ <int value="0" label="Success">A report was created and uploaded</int>
+ <int value="1" label="Suppressed">
+ A report was not uploaded because the CSD Whitelist killswitch was present
+ </int>
+ <int value="2" label="InvalidRequest">
+ A report was not uploaded because it could not be serialized
+ </int>
+ <int value="3" label="Cancelled">
+ A report upload was cancelled due to service shutdown
+ </int>
+ <int value="4" label="RequestFailed">A report upload failed</int>
+ <int value="5" label="InvalidResponse">
+ The response from a report upload was invalid
+ </int>
+ <int value="6" label="NoDownload">
+ A report was not uploaded because no binary download was found to report
+ </int>
+</enum>
+
<enum name="ResolutionCategory" type="int">
<int value="0" label="RESOLVE_SUCCESS"/>
<int value="1" label="RESOLVE_FAIL"/>
@@ -47271,15 +47299,6 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="3" label="AUTO_UPDATES_ONLY"/>
</enum>
-<enum name="UploadResult" type="int">
- <int value="0" label="Success"/>
- <int value="1" label="Suppressed">CSD Whitelist killswitch present</int>
- <int value="2" label="InvalidRequest"/>
- <int value="3" label="Cancelled"/>
- <int value="4" label="RequestFailed"/>
- <int value="5" label="InvalidResponse"/>
-</enum>
-
<enum name="UrlResolutionResult" type="int">
<int value="0" label="Absolute URL"/>
<int value="1" label="Resolutions Differ"/>
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698