tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6b101a8e6c04a627e87e153cc281396824dc7fc2..f349c846a953211ebb0f8bf3025694a06162e552 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -26018,6 +26018,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="SBIRS.DownloadCollectionTime" units="milliseconds">

[Mark P, 2014/07/01 17:22:08]

The revised summary is definitely clearer.  Perhaps we can revise the histogram
name too?  I'll suggest SBIRS.FindDownloadedBinariesTime,
SBIRS.CollectDownloadsTime, or SBIRS.ScanDownloadsTime as some examples.  In
short, it'd be nice to have a verb in there, and I have a slight preference for
plurality (downloads versus download, because that's more accurate) and accuracy
(specify binaries, because that's more accurate too).

[grt (UTC plus 2), 2014/07/01 17:49:06]

Done. I've gone with FindDownloadedBinaryTime since the operation (finding a
binary in profiles' history) never results in more than one binary being found
(zero found is a possibility).

+  <owner>grt@google.com</owner>
+  <summary>
+    The elapsed time to find the most recent binary download from all loaded
+    profiles when creating a safe browsing incident report.
+  </summary>
+</histogram>
+
 <histogram name="SBIRS.DroppedIncident" enum="IncidentType">
   <owner>grt@google.com</owner>
   <summary>
@@ -47200,12 +47208,23 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 </enum>
 
 <enum name="UploadResult" type="int">
-  <int value="0" label="Success"/>
-  <int value="1" label="Suppressed">CSD Whitelist killswitch present</int>
-  <int value="2" label="InvalidRequest"/>
-  <int value="3" label="Cancelled"/>
-  <int value="4" label="RequestFailed"/>
-  <int value="5" label="InvalidResponse"/>
+  <int value="0" label="Success">A report was created and uploaded</int>
+  <int value="1" label="Suppressed">
+    A report was not uploaded because the CSD Whitelist killswitch was present
+  </int>
+  <int value="2" label="InvalidRequest">
+    A report was not uploaded because it could not be serialized
+  </int>
+  <int value="3" label="Cancelled">
+    A report upload was cancelled due to service shutdown
+  </int>
+  <int value="4" label="RequestFailed">A report upload failed</int>
+  <int value="5" label="InvalidResponse">
+    The response from a report upload was invalid
+  </int>
+  <int value="6" label="NoDownload">
+    A report was not uploaded because no binary download was found to report

[Mark P, 2014/07/01 17:22:08]

The new detailed labels look good.  However, I still think you need to update
the the description.
You have
The result of a report upload ..
It could simply be
The result of an attempted report upload ...
or
The result of a planned report upload ...

Maybe while you're at it, you can change the name of the enum to
ReportProcessingResult as you suggest.
I can understand not wanting to change the name of the histogram; I won't
require you to do that.

[grt (UTC plus 2), 2014/07/01 17:49:06]

Done.

+  </int>
 </enum>
 
 <enum name="UrlResolutionResult" type="int">