Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 330653006: Include the latest binary download info in safe browsing incident reports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: iterator cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6b101a8e6c04a627e87e153cc281396824dc7fc2..2f6e7c2a2628e8f9ff9e8e8628c56b041a231147 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -26018,6 +26018,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="SBIRS.DownloadCollectionTime" units="milliseconds">
+ <owner>grt@google.com</owner>
+ <summary>
+ The elapsed time to collect the most recent binary download for a safe
Mark P 2014/06/30 23:11:06 This sounds awkward. What does "collect" mean in
+ browsing incident report.
+ </summary>
+</histogram>
+
<histogram name="SBIRS.DroppedIncident" enum="IncidentType">
<owner>grt@google.com</owner>
<summary>
@@ -47206,6 +47214,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="3" label="Cancelled"/>
<int value="4" label="RequestFailed"/>
<int value="5" label="InvalidResponse"/>
+ <int value="6" label="NoDownload">No download found to report</int>
Mark P 2014/06/30 23:11:06 This doesn't seem consistent with the description,
</enum>
<enum name="UrlResolutionResult" type="int">
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698