Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 330653004: Adds a field trial flag to control whether to use an alternate Instant search base page URL for pre… (Closed)

Created:
6 years, 6 months ago by kmadhusu
Modified:
6 years, 6 months ago
Reviewers:
samarth
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Project:
chromium
Visibility:
Public.

Description

Adds a field trial flag to control whether to use an alternate Instant search base page URL for prefetching search results. BUG=382694 TEST=Run chrome with the following field trial flag and observe the Instant search base page url. --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278824

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M chrome/browser/search/search.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/search/search.cc View 1 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kmadhusu
Please review. Thanks.
6 years, 6 months ago (2014-06-20 03:23:33 UTC) #1
samarth
lgtm https://codereview.chromium.org/330653004/diff/1/chrome/browser/search/search.cc File chrome/browser/search/search.cc (right): https://codereview.chromium.org/330653004/diff/1/chrome/browser/search/search.cc#newcode852 chrome/browser/search/search.cc:852: bool ShouldUseAltInstantURL() { Put this in an anonymous ...
6 years, 6 months ago (2014-06-20 04:43:23 UTC) #2
kmadhusu
Thanks. https://codereview.chromium.org/330653004/diff/1/chrome/browser/search/search.cc File chrome/browser/search/search.cc (right): https://codereview.chromium.org/330653004/diff/1/chrome/browser/search/search.cc#newcode852 chrome/browser/search/search.cc:852: bool ShouldUseAltInstantURL() { On 2014/06/20 04:43:23, samarth wrote: ...
6 years, 6 months ago (2014-06-20 16:01:53 UTC) #3
kmadhusu
The CQ bit was checked by kmadhusu@chromium.org
6 years, 6 months ago (2014-06-20 16:12:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/330653004/20001
6 years, 6 months ago (2014-06-20 16:15:54 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 20:22:48 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 21:21:39 UTC) #7
Message was sent while issue was closed.
Change committed as 278824

Powered by Google App Engine
This is Rietveld 408576698