Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2221)

Unified Diff: dart/tools/testing/dart/browser_controller.dart

Issue 330633002: Update co19 test suite to r737 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/browser_controller.dart
===================================================================
--- dart/tools/testing/dart/browser_controller.dart (revision 37262)
+++ dart/tools/testing/dart/browser_controller.dart (working copy)
@@ -1016,6 +1016,7 @@
status.browser.testBrowserOutput,
didTimeout: true);
status.currentTest.doneCallback(browserTestOutput);
+ status.lastTest = status.currentTest;
status.currentTest = null;
// We don't want to start a new browser if we are terminating.
@@ -1088,9 +1089,10 @@
status.currentTest.lastKnownMessage = '';
} else {
// TODO(ricow): Handle this better.
- print("This is bad, should never happen, getNextTest all full");
+ print("Browser requested next test before reporting previous result");
print("This happened for browser $browserId");
print("Old test was: ${status.currentTest.url}");
+ print("The test before that was: ${status.lastTest.url}");
print("Timed out tests:");
for (var v in timedOut) {
print(" $v");
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698