Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h

Issue 330623005: Revert 277655 "Remove more unretained" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
===================================================================
--- trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h (revision 277819)
+++ trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h (working copy)
@@ -223,22 +223,6 @@
// Returns the appropriate wallpaper resolution for all root windows.
static WallpaperResolution GetAppropriateResolution();
- // Returns custom wallpaper path. Append |sub_dir|, |user_id_hash| and |file|
- // to custom wallpaper directory.
- static base::FilePath GetCustomWallpaperPath(const char* sub_dir,
- const std::string& user_id_hash,
- const std::string& file);
-
- // Record data for User Metrics Analysis.
- static void RecordUma(User::WallpaperType type, int index);
-
- // Saves original custom wallpaper to |path| (absolute path) on filesystem
- // and starts resizing operation of the custom wallpaper if necessary.
- static void SaveCustomWallpaper(const std::string& user_id_hash,
- const base::FilePath& path,
- ash::WallpaperLayout layout,
- scoped_ptr<gfx::ImageSkia> image);
-
void SetCommandLineForTesting(base::CommandLine* command_line);
// Indicates imminent shutdown, allowing the WallpaperManager to remove any
@@ -252,6 +236,12 @@
// wallpaper of logged in user.
void EnsureLoggedInUserWallpaperLoaded();
+ // Returns custom wallpaper path. Append |sub_dir|, |user_id_hash| and |file|
+ // to custom wallpaper directory.
+ base::FilePath GetCustomWallpaperPath(const char* sub_dir,
+ const std::string& user_id_hash,
+ const std::string& file) const;
+
// Gets wallpaper information of logged in user.
bool GetLoggedInUserWallpaperInfo(WallpaperInfo* info);
@@ -453,6 +443,16 @@
MovableOnDestroyCallbackHolder on_finish,
const UserImage& user_image);
+ // Record data for User Metrics Analysis.
+ void RecordUma(User::WallpaperType type, int index) const;
+
+ // Saves original custom wallpaper to |path| (absolute path) on filesystem
+ // and starts resizing operation of the custom wallpaper if necessary.
+ void SaveCustomWallpaper(const std::string& user_id_hash,
+ const base::FilePath& path,
+ ash::WallpaperLayout layout,
+ scoped_ptr<gfx::ImageSkia> image) const;
+
// Creates new PendingWallpaper request (or updates currently pending).
void ScheduleSetUserWallpaper(const std::string& user_id, bool delayed);
« no previous file with comments | « no previous file | trunk/src/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698