content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 330623002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 330623002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test function modified. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('j') | content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 50044ae9e2bd94dae0e8ffe57202de5dc144819f..22d64385a0a940bcf8c130a76f89c28ce1aebca7 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2087,7 +2087,14 @@ public class ContentViewCore

@Override

public void onDestroyActionMode() {

mActionMode = null;

- if (mUnselectAllOnActionModeDismiss) mImeAdapter.unselect();

+ if (mUnselectAllOnActionModeDismiss) {

+ if (isSelectionEditable()) {

+ int selectionEnd = Selection.getSelectionEnd(mEditable);

+ mInputConnection.setSelection(selectionEnd, selectionEnd);

+ }

+ else

Ted C 2014/06/20 16:33:57 else should go on the previous line and since the

AKVT 2014/06/21 07:20:13 Done.

+ mImeAdapter.unselect();

+ }

getContentViewClient().onContextualActionBarHidden();

}