Source/core/editing/FrameSelection.cpp - Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated code based on self review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 16e620df97cae52317e1f1aee6263d23f48c64a3..50deb964fb161da3db43375bc9d1018d6ef7ca91 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1440,6 +1440,12 @@ bool FrameSelection::isInPasswordField() const

return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->isPasswordField();

}

+bool FrameSelection::isInTextField() const

+ HTMLTextFormControlElement* textControl = enclosingTextFormControl(start());

+ return isHTMLInputElement(textControl) && toHTMLInputElement(textControl)->isTextField();

void FrameSelection::notifyAccessibilityForSelectionChange()

{

if (m_selection.start().isNotNull() && m_selection.end().isNotNull()) {

« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/web/WebLocalFrameImpl.h » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')