| Index: chrome/browser/history/history_backend.cc
|
| diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
|
| index a3fb38f409a0820f40588c851b7b4924b3cd26af..b95ec460f6fb14acb01400ef0744d30b5243ff55 100644
|
| --- a/chrome/browser/history/history_backend.cc
|
| +++ b/chrome/browser/history/history_backend.cc
|
| @@ -1572,7 +1572,7 @@ void HistoryBackend::GetFavicons(
|
| int icon_types,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
|
| UpdateFaviconMappingsAndFetchImpl(NULL, icon_urls, icon_types,
|
| desired_size_in_dip, desired_scale_factors,
|
| bitmap_results);
|
| @@ -1582,7 +1582,7 @@ void HistoryBackend::GetLargestFaviconForURL(
|
| const GURL& page_url,
|
| const std::vector<int>& icon_types,
|
| int minimum_size_in_pixels,
|
| - favicon_base::FaviconBitmapResult* favicon_bitmap_result) {
|
| + favicon_base::FaviconRawBitmapResult* favicon_bitmap_result) {
|
| DCHECK(favicon_bitmap_result);
|
|
|
| if (!db_ || !thumbnail_db_)
|
| @@ -1603,16 +1603,18 @@ void HistoryBackend::GetLargestFaviconForURL(
|
|
|
| // Find the largest bitmap for each IconType placing in
|
| // |largest_favicon_bitmaps|.
|
| - std::map<favicon_base::IconType, FaviconBitmap> largest_favicon_bitmaps;
|
| + std::map<favicon_base::IconType, FaviconRawBitmap> largest_favicon_bitmaps;
|
| for (std::vector<IconMapping>::const_iterator i = icon_mappings.begin();
|
| i != icon_mappings.end(); ++i) {
|
| if (!(i->icon_type & required_icon_types))
|
| continue;
|
| - std::vector<FaviconBitmapIDSize> bitmap_id_sizes;
|
| - thumbnail_db_->GetFaviconBitmapIDSizes(i->icon_id, &bitmap_id_sizes);
|
| - FaviconBitmap& largest = largest_favicon_bitmaps[i->icon_type];
|
| - for (std::vector<FaviconBitmapIDSize>::const_iterator j =
|
| - bitmap_id_sizes.begin(); j != bitmap_id_sizes.end(); ++j) {
|
| + std::vector<FaviconRawBitmapIDSize> bitmap_id_sizes;
|
| + thumbnail_db_->GetFaviconRawBitmapIDSizes(i->icon_id, &bitmap_id_sizes);
|
| + FaviconRawBitmap& largest = largest_favicon_bitmaps[i->icon_type];
|
| + for (std::vector<FaviconRawBitmapIDSize>::const_iterator j =
|
| + bitmap_id_sizes.begin();
|
| + j != bitmap_id_sizes.end();
|
| + ++j) {
|
| if (largest.bitmap_id == 0 ||
|
| (largest.pixel_size.width() < j->pixel_size.width() &&
|
| largest.pixel_size.height() < j->pixel_size.height())) {
|
| @@ -1627,10 +1629,10 @@ void HistoryBackend::GetLargestFaviconForURL(
|
|
|
| // Find an icon which is larger than minimum_size_in_pixels in the order of
|
| // icon_types.
|
| - FaviconBitmap largest_icon;
|
| + FaviconRawBitmap largest_icon;
|
| for (std::vector<int>::const_iterator t = icon_types.begin();
|
| t != icon_types.end(); ++t) {
|
| - for (std::map<favicon_base::IconType, FaviconBitmap>::const_iterator f =
|
| + for (std::map<favicon_base::IconType, FaviconRawBitmap>::const_iterator f =
|
| largest_favicon_bitmaps.begin();
|
| f != largest_favicon_bitmaps.end();
|
| ++f) {
|
| @@ -1654,13 +1656,13 @@ void HistoryBackend::GetLargestFaviconForURL(
|
| }
|
|
|
| base::Time last_updated;
|
| - favicon_base::FaviconBitmapResult bitmap_result;
|
| + favicon_base::FaviconRawBitmapResult bitmap_result;
|
| bitmap_result.icon_url = icon_url;
|
| bitmap_result.icon_type = icon_type;
|
| - if (!thumbnail_db_->GetFaviconBitmap(largest_icon.bitmap_id,
|
| - &last_updated,
|
| - &bitmap_result.bitmap_data,
|
| - &bitmap_result.pixel_size)) {
|
| + if (!thumbnail_db_->GetFaviconRawBitmap(largest_icon.bitmap_id,
|
| + &last_updated,
|
| + &bitmap_result.bitmap_data,
|
| + &bitmap_result.pixel_size)) {
|
| return;
|
| }
|
|
|
| @@ -1678,7 +1680,7 @@ void HistoryBackend::GetFaviconsForURL(
|
| int icon_types,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
|
| DCHECK(bitmap_results);
|
| GetFaviconsFromDB(page_url, icon_types, desired_size_in_dip,
|
| desired_scale_factors, bitmap_results);
|
| @@ -1688,17 +1690,15 @@ void HistoryBackend::GetFaviconForID(
|
| favicon_base::FaviconID favicon_id,
|
| int desired_size_in_dip,
|
| ui::ScaleFactor desired_scale_factor,
|
| - std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
|
| std::vector<favicon_base::FaviconID> favicon_ids;
|
| favicon_ids.push_back(favicon_id);
|
| std::vector<ui::ScaleFactor> desired_scale_factors;
|
| desired_scale_factors.push_back(desired_scale_factor);
|
|
|
| // Get results from DB.
|
| - GetFaviconBitmapResultsForBestMatch(favicon_ids,
|
| - desired_size_in_dip,
|
| - desired_scale_factors,
|
| - bitmap_results);
|
| + GetFaviconRawBitmapResultsForBestMatch(
|
| + favicon_ids, desired_size_in_dip, desired_scale_factors, bitmap_results);
|
| }
|
|
|
| void HistoryBackend::UpdateFaviconMappingsAndFetch(
|
| @@ -1707,7 +1707,7 @@ void HistoryBackend::UpdateFaviconMappingsAndFetch(
|
| int icon_types,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
|
| UpdateFaviconMappingsAndFetchImpl(&page_url, icon_urls, icon_types,
|
| desired_size_in_dip, desired_scale_factors,
|
| bitmap_results);
|
| @@ -1730,8 +1730,8 @@ void HistoryBackend::MergeFavicon(
|
| favicon_id = thumbnail_db_->AddFavicon(icon_url, icon_type);
|
| }
|
|
|
| - std::vector<FaviconBitmapIDSize> bitmap_id_sizes;
|
| - thumbnail_db_->GetFaviconBitmapIDSizes(favicon_id, &bitmap_id_sizes);
|
| + std::vector<FaviconRawBitmapIDSize> bitmap_id_sizes;
|
| + thumbnail_db_->GetFaviconRawBitmapIDSizes(favicon_id, &bitmap_id_sizes);
|
|
|
| // If there is already a favicon bitmap of |pixel_size| at |icon_url|,
|
| // replace it.
|
| @@ -1739,13 +1739,14 @@ void HistoryBackend::MergeFavicon(
|
| bool replaced_bitmap = false;
|
| for (size_t i = 0; i < bitmap_id_sizes.size(); ++i) {
|
| if (bitmap_id_sizes[i].pixel_size == pixel_size) {
|
| - if (IsFaviconBitmapDataEqual(bitmap_id_sizes[i].bitmap_id, bitmap_data)) {
|
| - thumbnail_db_->SetFaviconBitmapLastUpdateTime(
|
| + if (IsFaviconRawBitmapDataEqual(bitmap_id_sizes[i].bitmap_id,
|
| + bitmap_data)) {
|
| + thumbnail_db_->SetFaviconRawBitmapLastUpdateTime(
|
| bitmap_id_sizes[i].bitmap_id, base::Time::Now());
|
| bitmap_identical = true;
|
| } else {
|
| - thumbnail_db_->SetFaviconBitmap(bitmap_id_sizes[i].bitmap_id,
|
| - bitmap_data, base::Time::Now());
|
| + thumbnail_db_->SetFaviconRawBitmap(
|
| + bitmap_id_sizes[i].bitmap_id, bitmap_data, base::Time::Now());
|
| replaced_bitmap = true;
|
| }
|
| break;
|
| @@ -1764,13 +1765,13 @@ void HistoryBackend::MergeFavicon(
|
| thumbnail_db_->SetFaviconOutOfDate(favicon_id);
|
|
|
| // Delete an arbitrary favicon bitmap to avoid going over the limit of
|
| - // |kMaxFaviconBitmapsPerIconURL|.
|
| - if (bitmap_id_sizes.size() >= kMaxFaviconBitmapsPerIconURL) {
|
| - thumbnail_db_->DeleteFaviconBitmap(bitmap_id_sizes[0].bitmap_id);
|
| + // |kMaxFaviconRawBitmapsPerIconURL|.
|
| + if (bitmap_id_sizes.size() >= kMaxFaviconRawBitmapsPerIconURL) {
|
| + thumbnail_db_->DeleteFaviconRawBitmap(bitmap_id_sizes[0].bitmap_id);
|
| favicon_sizes.erase(favicon_sizes.begin());
|
| }
|
| - thumbnail_db_->AddFaviconBitmap(favicon_id, bitmap_data, base::Time::Now(),
|
| - pixel_size);
|
| + thumbnail_db_->AddFaviconRawBitmap(
|
| + favicon_id, bitmap_data, base::Time::Now(), pixel_size);
|
| favicon_sizes.push_back(pixel_size);
|
| }
|
|
|
| @@ -1806,17 +1807,17 @@ void HistoryBackend::MergeFavicon(
|
| thumbnail_db_->GetIconMappingsForPageURL(page_url, icon_type, &icon_mappings);
|
|
|
| // Copy the favicon bitmaps mapped to |page_url| to the favicon at |icon_url|
|
| - // till the limit of |kMaxFaviconBitmapsPerIconURL| is reached.
|
| + // till the limit of |kMaxFaviconRawBitmapsPerIconURL| is reached.
|
| for (size_t i = 0; i < icon_mappings.size(); ++i) {
|
| - if (favicon_sizes.size() >= kMaxFaviconBitmapsPerIconURL)
|
| + if (favicon_sizes.size() >= kMaxFaviconRawBitmapsPerIconURL)
|
| break;
|
|
|
| if (icon_mappings[i].icon_url == icon_url)
|
| continue;
|
|
|
| - std::vector<FaviconBitmap> bitmaps_to_copy;
|
| - thumbnail_db_->GetFaviconBitmaps(icon_mappings[i].icon_id,
|
| - &bitmaps_to_copy);
|
| + std::vector<FaviconRawBitmap> bitmaps_to_copy;
|
| + thumbnail_db_->GetFaviconRawBitmaps(icon_mappings[i].icon_id,
|
| + &bitmaps_to_copy);
|
| for (size_t j = 0; j < bitmaps_to_copy.size(); ++j) {
|
| // Do not add a favicon bitmap at a pixel size for which there is already
|
| // a favicon bitmap mapped to |icon_url|. The one there is more correct
|
| @@ -1829,12 +1830,13 @@ void HistoryBackend::MergeFavicon(
|
|
|
| // Add the favicon bitmap as expired as it is not consistent with the
|
| // merged in data.
|
| - thumbnail_db_->AddFaviconBitmap(favicon_id,
|
| - bitmaps_to_copy[j].bitmap_data, base::Time(),
|
| - bitmaps_to_copy[j].pixel_size);
|
| + thumbnail_db_->AddFaviconRawBitmap(favicon_id,
|
| + bitmaps_to_copy[j].bitmap_data,
|
| + base::Time(),
|
| + bitmaps_to_copy[j].pixel_size);
|
| favicon_sizes.push_back(bitmaps_to_copy[j].pixel_size);
|
|
|
| - if (favicon_sizes.size() >= kMaxFaviconBitmapsPerIconURL)
|
| + if (favicon_sizes.size() >= kMaxFaviconRawBitmapsPerIconURL)
|
| break;
|
| }
|
| }
|
| @@ -1857,14 +1859,15 @@ void HistoryBackend::MergeFavicon(
|
| void HistoryBackend::SetFavicons(
|
| const GURL& page_url,
|
| favicon_base::IconType icon_type,
|
| - const std::vector<favicon_base::FaviconBitmapData>& favicon_bitmap_data) {
|
| + const std::vector<favicon_base::FaviconRawBitmapData>&
|
| + favicon_bitmap_data) {
|
| if (!thumbnail_db_ || !db_)
|
| return;
|
|
|
| DCHECK(ValidateSetFaviconsParams(favicon_bitmap_data));
|
|
|
| - // Build map of FaviconBitmapData for each icon url.
|
| - typedef std::map<GURL, std::vector<favicon_base::FaviconBitmapData> >
|
| + // Build map of FaviconRawBitmapData for each icon url.
|
| + typedef std::map<GURL, std::vector<favicon_base::FaviconRawBitmapData> >
|
| BitmapDataByIconURL;
|
| BitmapDataByIconURL grouped_by_icon_url;
|
| for (size_t i = 0; i < favicon_bitmap_data.size(); ++i) {
|
| @@ -1892,9 +1895,9 @@ void HistoryBackend::SetFavicons(
|
| icon_ids.push_back(icon_id);
|
|
|
| if (!data_modified)
|
| - SetFaviconBitmaps(icon_id, it->second, &data_modified);
|
| + SetFaviconRawBitmaps(icon_id, it->second, &data_modified);
|
| else
|
| - SetFaviconBitmaps(icon_id, it->second, NULL);
|
| + SetFaviconRawBitmaps(icon_id, it->second, NULL);
|
| }
|
|
|
| data_modified |=
|
| @@ -2010,7 +2013,7 @@ void HistoryBackend::UpdateFaviconMappingsAndFetchImpl(
|
| int icon_types,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
|
| // If |page_url| is specified, |icon_types| must be either a single icon
|
| // type or icon types which are equivalent.
|
| DCHECK(!page_url || icon_types == favicon_base::FAVICON ||
|
| @@ -2060,27 +2063,27 @@ void HistoryBackend::UpdateFaviconMappingsAndFetchImpl(
|
| }
|
| }
|
|
|
| - GetFaviconBitmapResultsForBestMatch(favicon_ids, desired_size_in_dip,
|
| - desired_scale_factors, bitmap_results);
|
| + GetFaviconRawBitmapResultsForBestMatch(
|
| + favicon_ids, desired_size_in_dip, desired_scale_factors, bitmap_results);
|
| }
|
|
|
| -void HistoryBackend::SetFaviconBitmaps(
|
| +void HistoryBackend::SetFaviconRawBitmaps(
|
| favicon_base::FaviconID icon_id,
|
| - const std::vector<favicon_base::FaviconBitmapData>& favicon_bitmap_data,
|
| + const std::vector<favicon_base::FaviconRawBitmapData>& favicon_bitmap_data,
|
| bool* favicon_bitmaps_changed) {
|
| if (favicon_bitmaps_changed)
|
| *favicon_bitmaps_changed = false;
|
|
|
| - std::vector<FaviconBitmapIDSize> bitmap_id_sizes;
|
| - thumbnail_db_->GetFaviconBitmapIDSizes(icon_id, &bitmap_id_sizes);
|
| + std::vector<FaviconRawBitmapIDSize> bitmap_id_sizes;
|
| + thumbnail_db_->GetFaviconRawBitmapIDSizes(icon_id, &bitmap_id_sizes);
|
|
|
| - std::vector<favicon_base::FaviconBitmapData> to_add = favicon_bitmap_data;
|
| + std::vector<favicon_base::FaviconRawBitmapData> to_add = favicon_bitmap_data;
|
|
|
| for (size_t i = 0; i < bitmap_id_sizes.size(); ++i) {
|
| const gfx::Size& pixel_size = bitmap_id_sizes[i].pixel_size;
|
| - std::vector<favicon_base::FaviconBitmapData>::iterator match_it =
|
| + std::vector<favicon_base::FaviconRawBitmapData>::iterator match_it =
|
| to_add.end();
|
| - for (std::vector<favicon_base::FaviconBitmapData>::iterator it =
|
| + for (std::vector<favicon_base::FaviconRawBitmapData>::iterator it =
|
| to_add.begin();
|
| it != to_add.end();
|
| ++it) {
|
| @@ -2090,21 +2093,20 @@ void HistoryBackend::SetFaviconBitmaps(
|
| }
|
| }
|
|
|
| - FaviconBitmapID bitmap_id = bitmap_id_sizes[i].bitmap_id;
|
| + FaviconRawBitmapID bitmap_id = bitmap_id_sizes[i].bitmap_id;
|
| if (match_it == to_add.end()) {
|
| - thumbnail_db_->DeleteFaviconBitmap(bitmap_id);
|
| + thumbnail_db_->DeleteFaviconRawBitmap(bitmap_id);
|
|
|
| if (favicon_bitmaps_changed)
|
| *favicon_bitmaps_changed = true;
|
| } else {
|
| - if (favicon_bitmaps_changed &&
|
| - !*favicon_bitmaps_changed &&
|
| - IsFaviconBitmapDataEqual(bitmap_id, match_it->bitmap_data)) {
|
| - thumbnail_db_->SetFaviconBitmapLastUpdateTime(
|
| - bitmap_id, base::Time::Now());
|
| + if (favicon_bitmaps_changed && !*favicon_bitmaps_changed &&
|
| + IsFaviconRawBitmapDataEqual(bitmap_id, match_it->bitmap_data)) {
|
| + thumbnail_db_->SetFaviconRawBitmapLastUpdateTime(bitmap_id,
|
| + base::Time::Now());
|
| } else {
|
| - thumbnail_db_->SetFaviconBitmap(bitmap_id, match_it->bitmap_data,
|
| - base::Time::Now());
|
| + thumbnail_db_->SetFaviconRawBitmap(
|
| + bitmap_id, match_it->bitmap_data, base::Time::Now());
|
|
|
| if (favicon_bitmaps_changed)
|
| *favicon_bitmaps_changed = true;
|
| @@ -2114,8 +2116,10 @@ void HistoryBackend::SetFaviconBitmaps(
|
| }
|
|
|
| for (size_t i = 0; i < to_add.size(); ++i) {
|
| - thumbnail_db_->AddFaviconBitmap(icon_id, to_add[i].bitmap_data,
|
| - base::Time::Now(), to_add[i].pixel_size);
|
| + thumbnail_db_->AddFaviconRawBitmap(icon_id,
|
| + to_add[i].bitmap_data,
|
| + base::Time::Now(),
|
| + to_add[i].pixel_size);
|
|
|
| if (favicon_bitmaps_changed)
|
| *favicon_bitmaps_changed = true;
|
| @@ -2123,7 +2127,7 @@ void HistoryBackend::SetFaviconBitmaps(
|
| }
|
|
|
| bool HistoryBackend::ValidateSetFaviconsParams(const std::vector<
|
| - favicon_base::FaviconBitmapData>& favicon_bitmap_data) const {
|
| + favicon_base::FaviconRawBitmapData>& favicon_bitmap_data) const {
|
| typedef std::map<GURL, size_t> BitmapsPerIconURL;
|
| BitmapsPerIconURL num_bitmaps_per_icon_url;
|
| for (size_t i = 0; i < favicon_bitmap_data.size(); ++i) {
|
| @@ -2142,23 +2146,21 @@ bool HistoryBackend::ValidateSetFaviconsParams(const std::vector<
|
|
|
| for (BitmapsPerIconURL::const_iterator it = num_bitmaps_per_icon_url.begin();
|
| it != num_bitmaps_per_icon_url.end(); ++it) {
|
| - if (it->second > kMaxFaviconBitmapsPerIconURL)
|
| + if (it->second > kMaxFaviconRawBitmapsPerIconURL)
|
| return false;
|
| }
|
| return true;
|
| }
|
|
|
| -bool HistoryBackend::IsFaviconBitmapDataEqual(
|
| - FaviconBitmapID bitmap_id,
|
| +bool HistoryBackend::IsFaviconRawBitmapDataEqual(
|
| + FaviconRawBitmapID bitmap_id,
|
| const scoped_refptr<base::RefCountedMemory>& new_bitmap_data) {
|
| if (!new_bitmap_data.get())
|
| return false;
|
|
|
| scoped_refptr<base::RefCountedMemory> original_bitmap_data;
|
| - thumbnail_db_->GetFaviconBitmap(bitmap_id,
|
| - NULL,
|
| - &original_bitmap_data,
|
| - NULL);
|
| + thumbnail_db_->GetFaviconRawBitmap(
|
| + bitmap_id, NULL, &original_bitmap_data, NULL);
|
| return new_bitmap_data->Equals(original_bitmap_data);
|
| }
|
|
|
| @@ -2167,7 +2169,7 @@ bool HistoryBackend::GetFaviconsFromDB(
|
| int icon_types,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* favicon_bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* favicon_bitmap_results) {
|
| DCHECK(favicon_bitmap_results);
|
| favicon_bitmap_results->clear();
|
|
|
| @@ -2186,34 +2188,36 @@ bool HistoryBackend::GetFaviconsFromDB(
|
| favicon_ids.push_back(icon_mappings[i].icon_id);
|
|
|
| // Populate |favicon_bitmap_results| and |icon_url_sizes|.
|
| - bool success = GetFaviconBitmapResultsForBestMatch(favicon_ids,
|
| - desired_size_in_dip, desired_scale_factors, favicon_bitmap_results);
|
| + bool success = GetFaviconRawBitmapResultsForBestMatch(favicon_ids,
|
| + desired_size_in_dip,
|
| + desired_scale_factors,
|
| + favicon_bitmap_results);
|
| UMA_HISTOGRAM_TIMES("History.GetFavIconFromDB", // historical name
|
| TimeTicks::Now() - beginning_time);
|
| return success && !favicon_bitmap_results->empty();
|
| }
|
|
|
| -bool HistoryBackend::GetFaviconBitmapResultsForBestMatch(
|
| +bool HistoryBackend::GetFaviconRawBitmapResultsForBestMatch(
|
| const std::vector<favicon_base::FaviconID>& candidate_favicon_ids,
|
| int desired_size_in_dip,
|
| const std::vector<ui::ScaleFactor>& desired_scale_factors,
|
| - std::vector<favicon_base::FaviconBitmapResult>* favicon_bitmap_results) {
|
| + std::vector<favicon_base::FaviconRawBitmapResult>* favicon_bitmap_results) {
|
| favicon_bitmap_results->clear();
|
|
|
| if (candidate_favicon_ids.empty())
|
| return true;
|
|
|
| - // Find the FaviconID and the FaviconBitmapIDs which best match
|
| + // Find the FaviconID and the FaviconRawBitmapIDs which best match
|
| // |desired_size_in_dip| and |desired_scale_factors|.
|
| // TODO(pkotwicz): Select bitmap results from multiple favicons once
|
| // content::FaviconStatus supports multiple icon URLs.
|
| favicon_base::FaviconID best_favicon_id = 0;
|
| - std::vector<FaviconBitmapID> best_bitmap_ids;
|
| + std::vector<FaviconRawBitmapID> best_bitmap_ids;
|
| float highest_score = kSelectFaviconFramesInvalidScore;
|
| for (size_t i = 0; i < candidate_favicon_ids.size(); ++i) {
|
| - std::vector<FaviconBitmapIDSize> bitmap_id_sizes;
|
| - thumbnail_db_->GetFaviconBitmapIDSizes(candidate_favicon_ids[i],
|
| - &bitmap_id_sizes);
|
| + std::vector<FaviconRawBitmapIDSize> bitmap_id_sizes;
|
| + thumbnail_db_->GetFaviconRawBitmapIDSizes(candidate_favicon_ids[i],
|
| + &bitmap_id_sizes);
|
|
|
| // Build vector of gfx::Size from |bitmap_id_sizes|.
|
| std::vector<gfx::Size> sizes;
|
| @@ -2239,7 +2243,7 @@ bool HistoryBackend::GetFaviconBitmapResultsForBestMatch(
|
| }
|
| }
|
|
|
| - // Construct FaviconBitmapResults from |best_favicon_id| and
|
| + // Construct FaviconRawBitmapResults from |best_favicon_id| and
|
| // |best_bitmap_ids|.
|
| GURL icon_url;
|
| favicon_base::IconType icon_type;
|
| @@ -2250,13 +2254,13 @@ bool HistoryBackend::GetFaviconBitmapResultsForBestMatch(
|
|
|
| for (size_t i = 0; i < best_bitmap_ids.size(); ++i) {
|
| base::Time last_updated;
|
| - favicon_base::FaviconBitmapResult bitmap_result;
|
| + favicon_base::FaviconRawBitmapResult bitmap_result;
|
| bitmap_result.icon_url = icon_url;
|
| bitmap_result.icon_type = icon_type;
|
| - if (!thumbnail_db_->GetFaviconBitmap(best_bitmap_ids[i],
|
| - &last_updated,
|
| - &bitmap_result.bitmap_data,
|
| - &bitmap_result.pixel_size)) {
|
| + if (!thumbnail_db_->GetFaviconRawBitmap(best_bitmap_ids[i],
|
| + &last_updated,
|
| + &bitmap_result.bitmap_data,
|
| + &bitmap_result.pixel_size)) {
|
| return false;
|
| }
|
|
|
|
|