chrome/browser/extensions/api/management/management_api.cc - Issue 330603004: Rename FaviconBitmapXxx to FaviconRawBitmapXxx

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 330603004: Rename FaviconBitmapXxx to FaviconRawBitmapXxx (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 1f45eb32f77498f648da64da7d108fc9850c365a..58c957ff0228a08760ad5b4fc72572a7e970b3ec 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -926,8 +926,8 @@ bool ManagementGenerateAppForLinkFunction::RunAsync() {

title_ = params->title;

launch_url_ = launch_url;

- favicon_service->GetFaviconImageForURL(

- FaviconService::FaviconForURLParams(

+ favicon_service->GetFaviconImageForPageURL(

+ FaviconService::FaviconForPageURLParams(

launch_url, favicon_base::FAVICON, gfx::kFaviconSize),

base::Bind(&ManagementGenerateAppForLinkFunction::OnFaviconForApp, this),

&cancelable_task_tracker_);